Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added consent Menu #4

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Added consent Menu #4

merged 2 commits into from
Jul 4, 2024

Conversation

Memeji
Copy link
Collaborator

@Memeji Memeji commented Jul 3, 2024

Description

Added a Consent Menu to store your consent options, big thanks to 0x40 for making it and helping to get it working on floof.


TODO

  • Remove toggle consent example.

Media

Example Media Embed


Changelog

🆑

  • add: Added fun :D
  • tweak: Tweaked fun
  • fix: Fixed fun!
  • remove: Removed fun :(

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file needed and not simply put in CVars?

@@ -187,6 +187,10 @@ binds:
- function: OpenLanguageMenu
type: State
key: L
- function: OpenConsentWindow
type: State
key: C
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key "C" is already used, you need to change this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually Alt+C see one line below

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct but during testing, this reported an error, non-fetal error tho.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we really need a hotkey for this. I doubt people will need to change their consent quickly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just an example and reading how the code works for those toggle LOOKS HORIBLE.
Please remake fully the function on how type "ConsentToggle" is generated in the UI and server or just remove it compleatly.

@Fansana Fansana merged commit 2102e29 into master Jul 4, 2024
6 of 9 checks passed
Floof-Station-Bot added a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants