Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for Gymnasium v0.29.0 #162

Merged

Conversation

rodrigodelazcano
Copy link
Member

@rodrigodelazcano rodrigodelazcano commented Jul 18, 2023

Description

  1. Fix CI issue with mujoco_py by specifying the cython version. Same issue as in Gymnasium, fixed in Limit cython version on mujoco-py option install Gymnasium#616.
  2. Close franka_config.xml after opening.
  3. Fix Deprecation Warning from numpy==1.25.0 in Franka environment

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rodrigodelazcano rodrigodelazcano changed the title Pin cython version Update to Gymnasium v0.29.0 Jul 19, 2023
@rodrigodelazcano rodrigodelazcano changed the title Update to Gymnasium v0.29.0 Fix CI for Gymnasium v0.29.0 Jul 19, 2023
@rodrigodelazcano rodrigodelazcano merged commit 69f0cea into Farama-Foundation:main Jul 19, 2023
5 checks passed
@rodrigodelazcano rodrigodelazcano deleted the cython-version-fix branch July 19, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant