update pyright to 1.1.383

[Kallinteris-Andreas]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Documentation only change (no code changed)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

• I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[pseudo-rnd-thoughts]

@Kallinteris-Andreas 213 errors, 6 warnings, 0 informations ooof and this is a most of the settings disabled.
I would consider moving to MyPY as it does better error checker for NumPy than PyRight

[Kallinteris-Andreas]

Some of the errors are straight up wrong (unless I am crazy)

 /home/runner/work/Gymnasium/Gymnasium/gymnasium/envs/mujoco/reacher_v4.py
  /home/runner/work/Gymnasium/Gymnasium/gymnasium/envs/mujoco/reacher_v4.py:29:35 - error: Argument of type "dict[str, int]" cannot be assigned to parameter "default_camera_config" of type "Dict[str, float | int] | None" in function "__init__"
    Type "dict[str, int]" is not assignable to type "Dict[str, float | int] | None"
      "dict[str, int]" is not assignable to "Dict[str, float | int]"
        Type parameter "_VT@dict" is invariant, but "int" is not the same as "float | int"
        Consider switching from "dict" to "Mapping" which is covariant in the value type
      "dict[str, int]" is not assignable to "None" (reportArgumentType)

int should be assignable to float | int

I am not strictly opposed to moving to MyPY, but it likely requires all the other Farama projects to change to MyPy also

[Kallinteris-Andreas]

note: I have edited my previous message by adding a "not", misstyping sorry

[Kallinteris-Andreas]

I have disabled reportAttributeAccessIssue, reportArgumentType as I think they create wrong issues

I have temporarily disabled the following, and marked them with TODO which can be fixed one at a time:
reportIndexIssue, reportReturnType, reportCallIssue, reportOperatorIssue, reportInvalidTypeForm, reportOptionalMemberAccess, reportRedeclaration, reportAssignmentType

#76 is immortal, you fix 1 issue 2 more shall take its place

[pseudo-rnd-thoughts]

#76 is immortal, you fix 1 issue 2 more shall take its place

Totally, this is part of my motivation for moving to MyPY as PyRight has minimal support for NumPy which is the cause of 90% of our issues

[pseudo-rnd-thoughts]

My only worry with this update is that it doesn't actually fix any of the type problems, just hides them better.

An alternative approach is to use something like https://github.com/beartype/beartype which operates during testing to check that the types passed to functions match the exacted type. Quite cool imo