-
-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error for pusher-v4
environment when mujoco>=3
#963
Conversation
What do we do for testing? |
Remove from the set of testing environments We could add a specialist CI case where mujoco < 3 is installed just in case. Is there anyway that we can check that a similar bug doesn't exist in other environments? |
|
pusher-v4
environment for mujoco<3
pusher-v4
environment for mujoco<3
pusher-v4
environment when mujoco>=3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kallinteris-Andreas Were you planning on anymore changes?
I have no idea why this is passing CI, pusher v4 should be failing its instanciacion |
It does but try_make_env catches the error and prevents the environment from being run |
Did not realize you commited to it, makes sense now |
Description
#950 noticed that pusher-v4 had collision issues which was isolated to a bug fixed in mujoco==3.0.0
This collision issue has a major implement on performance, therefore, raising an error for pusher-v4 when mujoco>=3
The issue will be fixed in pusher-v5