Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject, pre commit #414

Closed
wants to merge 7 commits into from
Closed

Add pyproject, pre commit #414

wants to merge 7 commits into from

Conversation

elliottower
Copy link
Member

Didn't change the requirements, adapted from pettingzoo pyproject. Didn't go through pre commit yet

@elliottower
Copy link
Member Author

I had to comment out a number of flake8 things and pyright errors, but I know at least this was one of them that seemed fixable:

https://stackoverflow.com/questions/69983472/how-to-satisfy-flake8-w605-invalid-escape-sequence-and-string-format-in

You can search through files for W605 and then remove that line and re-run the pre-commit in order to find the file which causes the issue. Not a huge deal I wouldn't imagine but just posting cause that's at least one I looked up.

@elliottower
Copy link
Member Author

It looks like the CONTRIBUTING.md file already has some instructions for installing pre-commit, I'm gonna guess that pre-commit was included in previous versions of the project? Tested it without the pre-commit config though and it gave an error, so until now I think that part of the documentation was invalid.

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this into two pr to make it clear what was changed for pyproject and pre commit for the future

@elliottower elliottower mentioned this pull request Jun 29, 2023
@elliottower elliottower mentioned this pull request Jun 29, 2023
@elliottower elliottower deleted the pyproject branch June 29, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants