Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added default schema sql server db settings #138

Merged
merged 5 commits into from
Aug 30, 2023
Merged

feat: added default schema sql server db settings #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70a9e65
chore: added ability to schema sql server operations
carlosgoias Aug 2, 2023
2dd0ede
lol
carlosgoias Aug 10, 2023
d68aafe
chore: fixed after review
carlosgoias Aug 10, 2023
02f203a
chore: modified slq server db settings with default schema constructor
carlosgoias Aug 30, 2023
d07a853
chore: merge with main
carlosgoias Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/KafkaFlow.Retry.SqlServer/Repositories/RetryQueueItemMessageRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public async Task<IList<RetryQueueItemMessageDbo>> GetMessagesOrderedAsync(IDbCo
entriesToLoad.Columns.Add("Id", typeof(int));
foreach (var retryQueueItemDbo in retryQueueItemsDbo)
{
System.Data.DataRow dr = entriesToLoad.NewRow();
var dr = entriesToLoad.NewRow();
dr["Id"] = retryQueueItemDbo.Id;
entriesToLoad.Rows.Add(dr);
}
Expand Down
5 changes: 1 addition & 4 deletions src/KafkaFlow.Retry.SqlServer/RetryDurableDefinitionBuilderExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
{
public static class RetryDurableDefinitionBuilderExtension
{
private const string schemaDefault = "dbo";

public static RetryDurableDefinitionBuilder WithSqlServerDataProvider(
this RetryDurableDefinitionBuilder retryDurableDefinitionBuilder,
string connectionString,
Expand Down Expand Up @@ -33,8 +31,7 @@ public static RetryDurableDefinitionBuilder WithSqlServerDataProvider(
.Create(
new SqlServerDbSettings(
connectionString,
databaseName,
schemaDefault)
databaseName)
)
);

Expand Down
20 changes: 19 additions & 1 deletion src/KafkaFlow.Retry.SqlServer/SqlServerDbSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@
[ExcludeFromCodeCoverage]
public class SqlServerDbSettings
{
private const string schemaDefault = "dbo";

/// <summary>
/// Creates a Sql Server database settings
/// Creates a Sql Server database settings with schema
/// </summary>
/// <param name="connectionString">The connection string of the Sql Server.</param>
/// <param name="databaseName">The database name.</param>
Expand All @@ -27,6 +29,22 @@ public SqlServerDbSettings(string connectionString, string databaseName, string
Schema = schema;
}

/// <summary>
/// Creates a Sql Server database settings
/// </summary>
/// <param name="connectionString">The connection string of the Sql Server.</param>
/// <param name="databaseName">The database name.</param>

public SqlServerDbSettings(string connectionString, string databaseName)
{
Guard.Argument(connectionString).NotNull().NotEmpty();
Guard.Argument(databaseName).NotNull().NotEmpty();

ConnectionString = connectionString;
DatabaseName = databaseName;
Schema = schemaDefault;
}

/// <summary>
/// Gets the connection string of the Sql Server database.
/// </summary>
Expand Down
Loading