Include Open Telemetry tracing #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simaoribeiro
commented
Oct 11, 2023
simaoribeiro
requested review from
joelfoliveira,
ailtonguitar,
brmagadutra,
ruiqbarbosa,
erik-catalao and
filipeesch
filipeesch
suggested changes
Oct 12, 2023
ruiqbarbosa
suggested changes
Oct 13, 2023
src/KafkaFlow.OpenTelemetry/OpenTelemetryConsumerEventsHandler.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.OpenTelemetry/OpenTelemetryProducerEventsHandler.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.OpenTelemetry/OpenTelemetryProducerEventsHandler.cs
Outdated
Show resolved
Hide resolved
joelfoliveira
approved these changes
Oct 13, 2023
src/KafkaFlow.OpenTelemetry/OpenTelemetryProducerEventsHandler.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.OpenTelemetry/OpenTelemetryProducerEventsHandler.cs
Outdated
Show resolved
Hide resolved
erik-catalao
approved these changes
Oct 13, 2023
JoaoRodriguesGithub
approved these changes
Oct 13, 2023
filipeesch
suggested changes
Oct 13, 2023
filipeesch
approved these changes
Oct 13, 2023
ruiqbarbosa
approved these changes
Oct 16, 2023
simaoribeiro
force-pushed
the
feat/include-open-telemetry
branch
from
8352ec3
to
78ce468
Compare
filipeesch
reviewed
Oct 16, 2023
src/KafkaFlow.IntegrationTests/Core/Middlewares/TriggerErrorSerializerMiddleware.cs
Outdated
Show resolved
Hide resolved
brmagadutra
approved these changes
Oct 16, 2023
brmagadutra
approved these changes
Oct 16, 2023
filipeesch
reviewed
Oct 17, 2023
filipeesch
reviewed
Oct 17, 2023
filipeesch
reviewed
Oct 17, 2023
filipeesch
reviewed
Oct 17, 2023
4 tasks
Include events for message produce and consume: - MessageConsumeCompleted - MessageConsumeError - MessageConsumeStarted - MessageProduceCompleted - MessageProduceError - MessageProduceStarted Include OpenTelemetry support for traces and baggage signals.
simaoribeiro
force-pushed
the
feat/include-open-telemetry
branch
from
61fcfb1
to
4527a11
Compare
ailtonguitar
approved these changes
Oct 19, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes several changes that allow telemetry events to be created when producing and consuming messages:
KafkaFlow.OpenTelemetrythat can be used to export trace information regarding the internal kafka events mentioned above.Note: The trace information may not be reliable when using batch consumers. This drawback is scheduled to be solved in a new major version https://github.com/Farfetch/kafkaflow/tree/release/3.0
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement