Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update middlewares.md #525

Closed
wants to merge 2 commits into from
Closed

Update middlewares.md #525

wants to merge 2 commits into from

Conversation

mhkolk
Copy link

@mhkolk mhkolk commented Feb 15, 2024

Description

Adding a note informing developers to use overloads of Add method for middleware lifetime

@joelfoliveira
Copy link
Contributor

joelfoliveira commented Feb 27, 2024

@mhkolk,

The pipeline is failing due to the commit message not following the conventional commits format as per the contribution guides.

Can you please amend the commit message and squash both commits (when trying to rebase the branch, GitHub created a merge commit) so we can merge the PR. Thank you.

@JoaoRodriguesGithub
Copy link
Contributor

Hi @mhkolk,

Since you did not address the requested changes so far, within the next 5 business days we will close this PR and create a new one in order to move forward.

We appreciate your contribution to our project and look forward to hearing from you soon. If you have any questions or need further assistance, don't hesitate to reach out.

@JoaoRodriguesGithub
Copy link
Contributor

Hi @mhkolk,

We will be closing this pull request.

Please feel free to respond to this message or reopen the issue if you'd like to continue the discussion or if you've encountered any new developments related to it.

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants