Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: does not serialize exception in ProduceTelemetry #539

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix: does not serialize exception in ProduceTelemetry #539

merged 1 commit into from
Mar 13, 2024

Conversation

ailtonguitar
Copy link
Contributor

@ailtonguitar ailtonguitar commented Mar 11, 2024 •
edited
Loading

Description

Avoid rethrow exception when there are errors on serialize exception data

Closes #537

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@ailtonguitar ailtonguitar force-pushed the fix/exception-serialization-error-producetelemetry branch from 5a89a5e to 2909522 Compare March 13, 2024 12:43
@JoaoRodriguesGithub JoaoRodriguesGithub merged commit 006a8b2 into master Mar 13, 2024
3 checks passed
@JoaoRodriguesGithub JoaoRodriguesGithub deleted the fix/exception-serialization-error-producetelemetry branch March 13, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelfoliveira joelfoliveira joelfoliveira approved these changes

@JoaoRodriguesGithub JoaoRodriguesGithub JoaoRodriguesGithub approved these changes

@ruiqbarbosa ruiqbarbosa ruiqbarbosa approved these changes

@brmagadutra brmagadutra brmagadutra approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report]: MicrosoftLogHandler is serializing exceptions using System.Text.Json
5 participants
@ailtonguitar @joelfoliveira @brmagadutra @ruiqbarbosa @JoaoRodriguesGithub