Skip to content

PoC: Include event-based instrumentation

Codacy Production / Codacy Static Code Analysis required action Sep 20, 2023 in 0s

18 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 18
           

Complexity increasing per file
==============================
- src/KafkaFlow.Abstractions/Events/Args/ProduceStartEventArgs.cs  1
- src/KafkaFlow.Abstractions/Events/Args/ProduceErrorEventArgs.cs  1
- src/KafkaFlow.Abstractions/Events/Args/ConsumeErrorEventArgs.cs  1
- src/KafkaFlow.Abstractions/Events/Args/ConsumeStartEventArgs.cs  1
- src/KafkaFlow.Abstractions/Events/EventsManager.cs  2
- src/KafkaFlow.OpenTelemetry/ExtensionMethods.cs  1
- src/KafkaFlow.OpenTelemetry/Trace/TracerConsumerMiddleware.cs  5
- src/KafkaFlow.OpenTelemetry/Trace/TracerProducerMiddleware.cs  7
- src/KafkaFlow.OpenTelemetry/Trace/KafkaFlowActivitySourceHelper.cs  3
- src/KafkaFlow/Consumers/ConsumerWorker.cs  2
         

See the complete overview on Codacy

Annotations

Check notice on line 22 in src/KafkaFlow.OpenTelemetry/ExtensionMethods.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow.OpenTelemetry/ExtensionMethods.cs#L22

'sender' is not used. Use discard parameter instead.

Check notice on line 23 in src/KafkaFlow.OpenTelemetry/ExtensionMethods.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow.OpenTelemetry/ExtensionMethods.cs#L23

'sender' is not used. Use discard parameter instead.

Check notice on line 24 in src/KafkaFlow.OpenTelemetry/ExtensionMethods.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow.OpenTelemetry/ExtensionMethods.cs#L24

'sender' is not used. Use discard parameter instead.

Check notice on line 25 in src/KafkaFlow.OpenTelemetry/ExtensionMethods.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow.OpenTelemetry/ExtensionMethods.cs#L25

'sender' is not used. Use discard parameter instead.

Check warning on line 13 in src/KafkaFlow.OpenTelemetry/Trace/KafkaFlowActivitySourceHelper.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow.OpenTelemetry/Trace/KafkaFlowActivitySourceHelper.cs#L13

Move this field's initializer into a static constructor.

Check notice on line 19 in src/KafkaFlow.OpenTelemetry/Trace/KafkaFlowActivitySourceHelper.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow.OpenTelemetry/Trace/KafkaFlowActivitySourceHelper.cs#L19

Replace this 'static readonly' declaration with 'const'.

Check notice on line 20 in src/KafkaFlow.OpenTelemetry/Trace/KafkaFlowActivitySourceHelper.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow.OpenTelemetry/Trace/KafkaFlowActivitySourceHelper.cs#L20

Replace this 'static readonly' declaration with 'const'.

Check notice on line 13 in src/KafkaFlow.OpenTelemetry/Trace/TracerConsumerMiddleware.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow.OpenTelemetry/Trace/TracerConsumerMiddleware.cs#L13

Replace this 'static readonly' declaration with 'const'.

Check warning on line 19 in src/KafkaFlow.OpenTelemetry/Trace/TracerConsumerMiddleware.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow.OpenTelemetry/Trace/TracerConsumerMiddleware.cs#L19

'context' is null on at least one execution path.

Check notice on line 15 in src/KafkaFlow.OpenTelemetry/Trace/TracerProducerMiddleware.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow.OpenTelemetry/Trace/TracerProducerMiddleware.cs#L15

Replace this 'static readonly' declaration with 'const'.

Check warning on line 21 in src/KafkaFlow.OpenTelemetry/Trace/TracerProducerMiddleware.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow.OpenTelemetry/Trace/TracerProducerMiddleware.cs#L21

'context' is null on at least one execution path.

Check warning on line 93 in src/KafkaFlow.OpenTelemetry/Trace/TracerProducerMiddleware.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow.OpenTelemetry/Trace/TracerProducerMiddleware.cs#L93

'context' is null on at least one execution path.

Check warning on line 101 in src/KafkaFlow/Configuration/ClusterConfigurationBuilder.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow/Configuration/ClusterConfigurationBuilder.cs#L101

'TProducerInstrumentationMiddleware' is not used in the method.

Check warning on line 110 in src/KafkaFlow/Configuration/ClusterConfigurationBuilder.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow/Configuration/ClusterConfigurationBuilder.cs#L110

Remove this commented out code.

Check warning on line 232 in src/KafkaFlow/Configuration/ConsumerConfigurationBuilder.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow/Configuration/ConsumerConfigurationBuilder.cs#L232

'T' is not used in the method.

Check notice on line 235 in src/KafkaFlow/Configuration/ConsumerConfigurationBuilder.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow/Configuration/ConsumerConfigurationBuilder.cs#L235

Remove the unused local variable 'type'.

Check failure on line 111 in src/KafkaFlow/Configuration/MiddlewareConfigurationBuilder.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow/Configuration/MiddlewareConfigurationBuilder.cs#L111

Remove this use of 'GetType' on a 'System.Type'.

Check warning on line 139 in src/KafkaFlow/Consumers/ConsumerWorker.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/KafkaFlow/Consumers/ConsumerWorker.cs#L139

'System.Exception' should not be thrown by user code.