Merge pull request #11 from diogobalseiro/master

Minor housekeeping
Farfetch · Mar 25, 2021 · bfa9205 · bfa9205
2 parents ec10b96 + 89ec746
commit bfa9205
Show file tree

Hide file tree

Showing 10 changed files with 78 additions and 92 deletions.
diff --git a/FNMNetworkMonitor.podspec b/FNMNetworkMonitor.podspec
@@ -1,7 +1,7 @@
 Pod::Spec.new do |spec|
   spec.name = 'FNMNetworkMonitor'
   spec.module_name = 'FNMNetworkMonitor'
-  spec.version = '11.0.0'
+  spec.version = '11.1.0'
   spec.summary = 'A network monitor'
   spec.homepage = 'https://github.com/Farfetch/network-monitor-ios'
   spec.license = 'MIT'
@@ -12,7 +12,7 @@ Pod::Spec.new do |spec|
   spec.requires_arc = true
 
   spec.cocoapods_version = '>= 1.7'
-  spec.swift_versions = ['5.0']
+  spec.swift_versions = ['5.0', '5.1', '5.2', '5.3']
 
   spec.source_files = 'NetworkMonitor/Classes/**/*.{h,m,swift}'
 end
diff --git a/NetworkMonitor.xcodeproj/project.pbxproj b/NetworkMonitor.xcodeproj/project.pbxproj
@@ -23,8 +23,8 @@
 		A39500101FD84F96001D6086 /* FNMDebugSummaryTableViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = A395000F1FD84F96001D6086 /* FNMDebugSummaryTableViewCell.swift */; };
 		A395FFFD1FD83AB1001D6086 /* FNMNetworkMonitorURLProtocol.swift in Sources */ = {isa = PBXBuildFile; fileRef = A395FFE31FD83AB1001D6086 /* FNMNetworkMonitorURLProtocol.swift */; };
 		A3DA63EE201B3637002CB2C0 /* FNMViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = A3DA63ED201B3637002CB2C0 /* FNMViewController.swift */; };
-		A3E27FC51FC81F9000245188 /* Cold-Start-First-Party-Calls.json in Resources */ = {isa = PBXBuildFile; fileRef = A3E27FC11FC81F8400245188 /* Cold-Start-First-Party-Calls.json */; };
-		A3E27FC71FC81F9000245188 /* Cold-Start-Third-Party-Calls.json in Resources */ = {isa = PBXBuildFile; fileRef = A3E27FC01FC81F8400245188 /* Cold-Start-Third-Party-Calls.json */; };
+		A3E27FC51FC81F9000245188 /* Request-Nodes-A.json in Resources */ = {isa = PBXBuildFile; fileRef = A3E27FC11FC81F8400245188 /* Request-Nodes-A.json */; };
+		A3E27FC71FC81F9000245188 /* Request-Nodes-B.json in Resources */ = {isa = PBXBuildFile; fileRef = A3E27FC01FC81F8400245188 /* Request-Nodes-B.json */; };
 		DDD462ED24DB54C600F14CD6 /* FNMNetworkMonitor.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = F793CA4D1F9E361900AA9C41 /* FNMNetworkMonitor.framework */; };
 		DDD462EE24DB54C600F14CD6 /* FNMNetworkMonitor.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = F793CA4D1F9E361900AA9C41 /* FNMNetworkMonitor.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
 		F737BF202080F97D00ECCDE3 /* FNMHTTPRequestRecord.swift in Sources */ = {isa = PBXBuildFile; fileRef = F737BF1F2080F97C00ECCDE3 /* FNMHTTPRequestRecord.swift */; };
@@ -106,8 +106,8 @@
 		A395FFFA1FD83AB1001D6086 /* FNMNetworkMonitor.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FNMNetworkMonitor.swift; sourceTree = "<group>"; };
 		A395FFFC1FD83AB1001D6086 /* FNMAdditions.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FNMAdditions.swift; sourceTree = "<group>"; };
 		A3DA63ED201B3637002CB2C0 /* FNMViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FNMViewController.swift; sourceTree = "<group>"; };
-		A3E27FC01FC81F8400245188 /* Cold-Start-Third-Party-Calls.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = "Cold-Start-Third-Party-Calls.json"; sourceTree = "<group>"; };
-		A3E27FC11FC81F8400245188 /* Cold-Start-First-Party-Calls.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = "Cold-Start-First-Party-Calls.json"; sourceTree = "<group>"; };
+		A3E27FC01FC81F8400245188 /* Request-Nodes-B.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = "Request-Nodes-B.json"; sourceTree = "<group>"; };
+		A3E27FC11FC81F8400245188 /* Request-Nodes-A.json */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.json; path = "Request-Nodes-A.json"; sourceTree = "<group>"; };
 		F737BF1F2080F97C00ECCDE3 /* FNMHTTPRequestRecord.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = FNMHTTPRequestRecord.swift; sourceTree = "<group>"; };
 		F737BF212080F9B700ECCDE3 /* FNMHTTPRequestRecord+Codable.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "FNMHTTPRequestRecord+Codable.swift"; sourceTree = "<group>"; };
 		F737BF252080FC9100ECCDE3 /* FNMProfile.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FNMProfile.swift; sourceTree = "<group>"; };
@@ -237,8 +237,8 @@
 				F7A5E799208E29E4008C74CE /* Matching-Profiles-1.json */,
 				F7A5E79B208E2C96008C74CE /* Matching-Profiles-2.json */,
 				F792A3912099D0A500D9C894 /* Matching-Profiles-3.json */,
-				A3E27FC11FC81F8400245188 /* Cold-Start-First-Party-Calls.json */,
-				A3E27FC01FC81F8400245188 /* Cold-Start-Third-Party-Calls.json */,
+				A3E27FC11FC81F8400245188 /* Request-Nodes-A.json */,
+				A3E27FC01FC81F8400245188 /* Request-Nodes-B.json */,
 			);
 			path = Resources;
 			sourceTree = "<group>";
@@ -520,8 +520,8 @@
 				F76084C72409678E00451AE8 /* Image.png in Resources */,
 				F792A3922099D0A500D9C894 /* Matching-Profiles-3.json in Resources */,
 				F7DA8306240956280095D93F /* Generic-Profile-Response.json in Resources */,
-				A3E27FC51FC81F9000245188 /* Cold-Start-First-Party-Calls.json in Resources */,
-				A3E27FC71FC81F9000245188 /* Cold-Start-Third-Party-Calls.json in Resources */,
+				A3E27FC51FC81F9000245188 /* Request-Nodes-A.json in Resources */,
+				A3E27FC71FC81F9000245188 /* Request-Nodes-B.json in Resources */,
 				F77D3F32209A16F0008F5E56 /* Generic-Profiles-Duplicates.json in Resources */,
 				F7A5E79C208E2C96008C74CE /* Matching-Profiles-2.json in Resources */,
 				F7A5E79A208E29E4008C74CE /* Matching-Profiles-1.json in Resources */,

diff --git a/NetworkMonitor/Classes/Debug/Controller/DebugDetailBodyViewController.swift b/NetworkMonitor/Classes/Debug/Controller/DebugDetailBodyViewController.swift
@@ -12,7 +12,6 @@ import UIKit
 final class DebugDetailBodyViewController: UIViewController, HighlightReloadable {
 
     // MARK: Properties
-
     let recordBodyDetailInfo: RecordBodyDetailInfo
 
     private let titleLabel = UILabel()
@@ -21,7 +20,6 @@ final class DebugDetailBodyViewController: UIViewController, HighlightReloadable
     var highlight: String = ""
 
     // MARK: Lifecycle
-
     init(recordBodyDetailInfo: RecordBodyDetailInfo) {
 
         self.recordBodyDetailInfo = recordBodyDetailInfo
@@ -43,7 +41,6 @@ final class DebugDetailBodyViewController: UIViewController, HighlightReloadable
     }
 
     // MARK: Public
-
     func reloadData(with highlight: String?) {
 
         self.highlight = highlight ?? ""
@@ -57,7 +54,6 @@ final class DebugDetailBodyViewController: UIViewController, HighlightReloadable
 private extension DebugDetailBodyViewController {
 
     // MARK: - Constants
-
     enum Constants {
 
            static let goldColor = UIColor(red: 196.0, green: 170.0, blue: 132.0, alpha: 1.0)
@@ -66,7 +62,6 @@ private extension DebugDetailBodyViewController {
     }
 
     // MARK: - Layout Configuration
-
     func configureViews() {
 
         self.view.addSubview(self.titleLabel)

diff --git a/NetworkMonitor/Classes/Debug/Controller/DebugDetailHeadersViewController.swift b/NetworkMonitor/Classes/Debug/Controller/DebugDetailHeadersViewController.swift
@@ -12,7 +12,6 @@ import UIKit
 final class DebugDetailHeadersViewController: UIViewController, HighlightReloadable {
 
     // MARK: Properties
-
     let recordHeaderDetailInfo: RecordHeaderDetailInfo
 
     private let tableView = UITableView(frame: .zero,
@@ -21,7 +20,6 @@ final class DebugDetailHeadersViewController: UIViewController, HighlightReloada
     var highlight: String = ""
 
     // MARK: - Lifecycle
-
     init(recordHeaderDetailInfo: RecordHeaderDetailInfo) {
 
         self.recordHeaderDetailInfo = recordHeaderDetailInfo
@@ -43,7 +41,6 @@ final class DebugDetailHeadersViewController: UIViewController, HighlightReloada
     }
 
     // MARK: Public
-
     func reloadData(with highlight: String?) {
 
         self.highlight = highlight ?? ""
@@ -57,14 +54,12 @@ final class DebugDetailHeadersViewController: UIViewController, HighlightReloada
 private extension DebugDetailHeadersViewController {
 
     // MARK: - Constants
-
     enum Constants {
 
         static let tableViewEstimatedHeight: CGFloat = 60.0
     }
 
     // MARK: - Layout Configuration
-
     func configureViews() {
 
         self.configureTableView()
@@ -107,7 +102,6 @@ private extension DebugDetailHeadersViewController {
 }
 
 // MARK: - DebugDetailHeadersViewController: UITableViewDataSource
-
 extension DebugDetailHeadersViewController: UITableViewDataSource {
 
     enum DebugDetailViewControllerSection: Int {
@@ -200,7 +194,6 @@ extension DebugDetailHeadersViewController: UITableViewDataSource {
 }
 
 // MARK: - DebugDetailHeadersViewController: UITableViewDelegate
-
 extension DebugDetailHeadersViewController: UITableViewDelegate {
 
     func tableView(_ tableView: UITableView, shouldHighlightRowAt indexPath: IndexPath) -> Bool {

diff --git a/README.md b/README.md
@@ -7,7 +7,7 @@
 
 ## What is this ?
 
-FNMNetworkMonitor is an iOS networking framework that can be used to monitor the network of an iOS app. 
+FNMNetworkMonitor is a swift iOS networking framework that can be used to monitor the network of an iOS app. 
 It makes **debugging** the network easy, allowing you to pinpoint the root cause of network related problems in your app and share those requests via email. 
 it can also **mock** network requests, making it much easier to use incomplete APIs or model specific states for unit testing.
 
@@ -95,6 +95,4 @@ List of [Maintainers](MAINTAINERS.md)
 
 ## License
 
-[MIT](LICENSE)
-
-
+The FNMNetworkMonitor is released under the [MIT](LICENSE) license. See the LICENSE file for more details.
diff --git a/Sample/ViewController.swift b/Sample/ViewController.swift
@@ -13,9 +13,9 @@ final class ViewController: UIViewController {
 
     enum Constants {
 
-        static let labelTopPadding: CGFloat = 50.0
-        static let imageSidePadding: CGFloat = 10.0
-        static let imageBorderWidth: CGFloat = 5.0
+        static let labelTopPadding: CGFloat = 60.0
+        static let imageSidePadding: CGFloat = 15.0
+        static let imageBorderWidth: CGFloat = 3.0
 
         static let robotURL = "https://www.alphabet.com/robots.txt"
         static let errorURL = "https://www.ohthehumanity.error"