Update download extension icons in readme #1180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1160
As stated in the Issue, I have both the square and rounded versions of the Chrome icon, here in this PR I opted to use the squared version (to be as similar as possible to the current icon), but I personally think the round icon looks the best, so maybe we could switch to that.
Another thing to note in this PR is that the colors of the old and new Firefox download icon are slightly different (the new one has a darker blue), but that is easy to modify since it is a high-quality PNG picture, it is a matter of copying the color of the old icon and applying it on the new one using Paint/Photoshop.
And last but not least, I wasn't sure what the convention for icons is for FastForward. I wasn't sure if the icons should be somewhere in the project's folder (like in the
docs
folder), or if it should be hosted externally. Since the current icons being used are fromuser-images.githubusercontent.com
, I assumed the project wants to keep its icons externalized, so I uploaded them toimgur.com
(but no clue if this was the preferred way).Here's the upload link with all three icons: https://imgur.com/a/2luHAqC
Fix(es):
There was no fix, this PR updates the Firefox and Chrome download icons in the project readme.