Spearbit Reaudit Week 1 Changes #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small Clean Up
Use Transient Storage
Only `solverOp.solver` can call `reconcile()`
lower bits are already stripped
break condition at the end is equivalent
refactor _executeSolverOperation/ _executeUserOperation
fix: add _validateSolverOpDeadline for _getBidAmount
docs: update comment for trustedOpHash
refactor: _handleAltOpHash deadline check for better readability
fix: return nonce directly if increment is sequential
fix: Compensate for Missing Nonce 0
docs: update code documentation for better clarity
refactor: reuse _isDAppSignatory in getGovFromControl
docs: add clear comment why we use untrusted hash
fix: add comment why name/symbol/decimals are lowercase
docs: remove EOA from comments
allow for better code readability and reduces duplicated logic
New Storage.sol Tests
BenSparksCode
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base branch for any changes during the Spearbit audit fix review period