refactor scala object deserialization #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
force-pushed
the
refactor-scala-object-deser
branch
from
398e085
to
5ab556f
Compare
pjfanning
added a commit
that referenced
this pull request
Dec 1, 2023
* refactor scala object deserialization * Update build.sbt * Update Classes.scala * refactor beanintrospector * Update build.sbt * Update CaseObjectDeserializerTest.scala
pjfanning
added a commit
that referenced
this pull request
Dec 1, 2023
* refactor scala object deserialization * Update build.sbt * Update Classes.scala * refactor beanintrospector * Update build.sbt * Update CaseObjectDeserializerTest.scala Update ScalaObjectDeserializerModule.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the work in #656 - thanks to @marcinbelicki for driving this
I dislike the large element of refactor in #656 - I see having all the new classes instead of just refactoring ClassW to be a problem.
The changes in this PR still leaves behind a messy call to ClassW.isScalaObject in BeanIntrospector.