Fix Locator not being fully initialized when setLocator is called #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r is being called
cowtowncoder
approved these changes
Nov 12, 2024
cowtowncoder
added a commit
that referenced
this pull request
Nov 12, 2024
cowtowncoder
added a commit
that referenced
this pull request
Nov 12, 2024
|
@philippn I think you figure it out all out; merged as-is, for inclusion in whatever next version is (probably 7.1.1). Also backported in 6.7, but not sure there will be new releases from there. |
|
@cowtowncoder Great to hear that, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this is a PR for #213.
It also modifies one of the SAX tests to test for systemId. The test fails with 7.1.0 and succeeds with 7.1.1-SNAPSHOT. I wasn't totally sure about the naming of the variable locator in the test though. Most of the variables are prefixed with _, I interpreted it that this might indicate public/direct use and went without it for the locator.
feel free to change anything, as you see fit.
Thanks in advance and kind regards,
Philipp