Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the design of FedML Python Agent to a decentralized architecture that supports Launch Master, Launch Slave, Deploy Master, and Deploy Slave at the same time. #2163

Merged
merged 46 commits into from
Jun 28, 2024

Merge branch 'dev/v0.7.0' into alexleung/dev_v070_for_refactor

a932082
Select commit
Loading
Failed to load commit list.
Merged

Adjust the design of FedML Python Agent to a decentralized architecture that supports Launch Master, Launch Slave, Deploy Master, and Deploy Slave at the same time. #2163

Merge branch 'dev/v0.7.0' into alexleung/dev_v070_for_refactor
a932082
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks failed Jun 26, 2024 in 14s

14 secrets uncovered!

14 secrets were uncovered from the scan of 46 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #2163: alexleung/dev_v070_for_refactor 👉 dev/v0.7.0
GitGuardian id GitGuardian status Secret Commit Filename
11782617 Triggered Generic High Entropy Secret 0491bb7 .github/workflows/registry-runners/Dockerfile View secret
11782617 Triggered Generic High Entropy Secret 7a0963e .github/workflows/registry-runners/windows.bat View secret
11782617 Triggered Generic High Entropy Secret 942b223 .github/workflows/registry-runners/Dockerfile View secret
11782617 Triggered Generic High Entropy Secret fd038b5 .github/workflows/registry-runners/Dockerfile View secret
11782617 Triggered Generic High Entropy Secret 942b223 .github/workflows/registry-runners/windows.bat View secret
11782618 Triggered Generic High Entropy Secret 0491bb7 .github/workflows/registry-runners/windows.ps1 View secret
11782618 Triggered Generic High Entropy Secret fd038b5 .github/workflows/registry-runners/windows.ps1 View secret
11782618 Triggered Generic High Entropy Secret 7a0963e .github/workflows/registry-runners/windows.ps1 View secret
9453265 Triggered Generic High Entropy Secret 942b223 python/fedml/api/api_test.py View secret
9453265 Triggered Generic High Entropy Secret 7233d62 python/fedml/api/api_test.py View secret
9453265 Triggered Generic High Entropy Secret aa813a0 python/fedml/api/api_test.py View secret
9453265 Triggered Generic High Entropy Secret 11ef2a5 python/fedml/api/api_test.py View secret
9453265 Triggered Generic High Entropy Secret 78e310c python/fedml/api/api_test.py View secret
5692101 Triggered Generic High Entropy Secret a932082 python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.