Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): add batch updating #157

Merged
merged 60 commits into from
Jun 6, 2023
Merged

feat(admin): add batch updating #157

merged 60 commits into from
Jun 6, 2023

Conversation

layaxx
Copy link
Member

@layaxx layaxx commented Mar 24, 2023

listens for changes to localized entities and offers batch translation for updated entities

fix #109

layaxx and others added 24 commits March 18, 2023 22:05
strapi v4.8 seems to throw error if Td element is not direct child of Tr element

fix #142
…-undefined-reading-row

fix(admin): fix error with strapi v4.8
## strapi-provider-translate-libretranslate [1.0.1](https://github.com/fekide/strapi-plugin-translate/compare/strapi-provider-translate-libretranslate@[email protected]) (2023-03-19)

### Dependencies

* **strapi-plugin-translate:** upgraded to 1.1.2
## [1.1.2](https://github.com/Fekide/strapi-plugin-translate/compare/[email protected]@1.1.2) (2023-03-19)

### Bug Fixes

* **admin:** fix error with strapi v4.8 ([cdf22ad](cdf22ad)), closes [#142](#142)
* **provider-libretranslate:** throw error if no API URL is provided ([ad35472](ad35472))

### Features

* **provider:** add libretranslate provider ([dafff33](dafff33)), closes [#87](#87)
## [1.1.2](https://github.com/fekide/strapi-plugin-translate/compare/strapi-provider-translate-deepl@[email protected]) (2023-03-19)

### Bug Fixes

* **admin:** fix error with strapi v4.8 ([cdf22ad](cdf22ad)), closes [#142](#142)
* **provider-libretranslate:** throw error if no API URL is provided ([ad35472](ad35472))

### Features

* **provider:** add libretranslate provider ([dafff33](dafff33)), closes [#87](#87)
Bumps [multi-semantic-release](https://github.com/dhoulb/multi-semantic-release) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/dhoulb/multi-semantic-release/releases)
- [Commits](dhoulb/multi-semantic-release@v3.0.1...v3.0.2)

---
updated-dependencies:
- dependency-name: multi-semantic-release
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…antic-release-3.0.2

build(deps-dev): bump multi-semantic-release from 3.0.1 to 3.0.2
One example test included for now with direct translation. Not yet suitable for ci run since the
setup is not fully automated yet
Adds two tests for direct translation and a single one for batch translation.

fix #135
waited on wrong url after uid regeneration
Allow testing codebase for multiple supported strapi versions
listens for changes to localized entities and offers batch translation for updated entities

fix #109
@layaxx layaxx requested a review from sargreal March 24, 2023 12:43
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #157 (31c5ebc) into next (d5039e8) will increase coverage by 0.91%.
The diff coverage is 19.35%.

@@            Coverage Diff             @@
##             next     #157      +/-   ##
==========================================
+ Coverage   42.67%   43.58%   +0.91%     
==========================================
  Files          43       52       +9     
  Lines         771      936     +165     
  Branches      162      197      +35     
==========================================
+ Hits          329      408      +79     
- Misses        303      362      +59     
- Partials      139      166      +27     
Flag Coverage Δ
unittests 43.58% <19.35%> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugin/server/bootstrap.js 0.00% <0.00%> (ø)
plugin/server/content-types/index.js 0.00% <0.00%> (ø)
plugin/server/content-types/updated-entry/index.js 0.00% <0.00%> (ø)
plugin/server/controllers/index.js 0.00% <0.00%> (ø)
plugin/server/controllers/updated-entry.js 0.00% <0.00%> (ø)
plugin/server/routes/translate.js 0.00% <ø> (ø)
plugin/server/routes/updated-entry.js 0.00% <0.00%> (ø)
plugin/server/services/index.js 0.00% <0.00%> (ø)
plugin/server/services/updated-entry.js 0.00% <0.00%> (ø)
plugin/server/controllers/translate.js 21.60% <14.28%> (-0.44%) ⬇️
... and 4 more

... and 4 files with indirect coverage changes

@layaxx layaxx marked this pull request as draft March 27, 2023 10:13
layaxx added 2 commits March 27, 2023 13:50
add option to ignore contentTypes and wether to regenerate uids or not
@layaxx layaxx marked this pull request as ready for review March 27, 2023 12:04
sargreal and others added 12 commits April 9, 2023 23:12
docs(readme): update content
…-have-a-problem-with-bound-entities

fix(relations): make default behavior translations
…tion-with-relations-in-components

 fix(direct-translation): issue with translating relations in components
## strapi-provider-translate-libretranslate [1.0.2](https://github.com/fekide/strapi-plugin-translate/compare/strapi-provider-translate-libretranslate@[email protected]) (2023-04-09)

### Dependencies

* **strapi-plugin-translate:** upgraded to 1.1.3
## [1.1.3](https://github.com/Fekide/strapi-plugin-translate/compare/[email protected]@1.1.3) (2023-04-09)

### Bug Fixes

* **direct-translation:** issue with translating relations in components ([9599782](9599782)), closes [#152](#152)
* **relations:** make default behavior translations ([bf03402](bf03402)), closes [#161](#161)
## [1.1.3](https://github.com/fekide/strapi-plugin-translate/compare/strapi-provider-translate-deepl@[email protected]) (2023-04-09)

### Bug Fixes

* **direct-translation:** issue with translating relations in components ([9599782](9599782)), closes [#152](#152)
* **relations:** make default behavior translations ([bf03402](bf03402)), closes [#161](#161)
by default, only one row per contentType is shown, which can be expanded to display all updates
@layaxx layaxx requested a review from sargreal June 2, 2023 16:08
Copy link
Member

@sargreal sargreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update modal seems a bit too crowded, there should be some margins etc.

Also the messages shown are a bit confusing, these should be different from the messages for the direct translation right?

image

add margins to batch-update dialog, translate all text
@layaxx layaxx requested a review from sargreal June 3, 2023 16:45
Copy link
Member

@sargreal sargreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sargreal sargreal merged commit d5755b2 into next Jun 6, 2023
@fekide-bot
Copy link

🎉 This PR is included in version 1.0.3-next.1 🎉

The release is available on npm package (@next dist-tag)

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.2.0-next.1 🎉

The release is available on npm package (@next dist-tag)

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.1.4-next.1 🎉

The release is available on npm package (@next dist-tag)

Your semantic-release bot 📦🚀

@Discountrobot
Copy link

Any chance this is getting release soon? 🙏

@fekide-bot
Copy link

🎉 This PR is included in version 1.3.0-next.1 🎉

The release is available on npm package (@next dist-tag)

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.1.13-next.1 🎉

The release is available on npm package (@next dist-tag)

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.0.12-next.1 🎉

The release is available on npm package (@next dist-tag)

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.1.16-next.1 🎉

The release is available on npm package (@next dist-tag)

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.0.15-next.1 🎉

The release is available on npm package (@next dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants