Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Mail Framework Mod #8

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Digus
Copy link

@Digus Digus commented Dec 30, 2019

Adding a check that, when the letter was not added with FeTK, it also check is it's a LetterViewerMenu.
If it's not, it's probably a sub classe added by another mod, so it does nothing in that case.
Otherwise, it does was it's supposed to do with the vanilla mail.

This pull request also includes additions made by Pathoschild.

@dy-lin
Copy link

dy-lin commented Jan 9, 2021

Error message seen in log file: https://smapi.io/log/d9fe498a25fd47f6bcb3c1e929281b38

This mod failed in the Display.MenuChanged event. Technical details: 
System.IndexOutOfRangeException: Index was outside the bounds of the array.
  at FelixDev.StardewMods.FeTK.Framework.Services.MailManager.GetMailContentForGameMail (System.String mailId) <0x12fb65f20 + 0x00134> in <filename unknown>:0 
  at FelixDev.StardewMods.FeTK.Framework.Services.MailManager.OnMenuChanged (System.Object sender, StardewModdingAPI.Events.MenuChangedEventArgs e) <0x12d0aecc0 + 0x00294> in <filename unknown>:0 
  at StardewModdingAPI.Framework.Events.ManagedEvent`1[TEventArgs].Raise (StardewModdingAPI.Framework.Events.TEventArgs args, System.Func`2 match) <0x1197258b0 + 0x00593> in <filename unknown>:0 

@Digus
Copy link
Author

Digus commented Jan 10, 2021

By analyzing the log and the code, it does not seem the error is specifically related to the changes added by this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants