Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Sprint field in PR #110

Merged
merged 11 commits into from
Nov 9, 2022
Merged

Check Sprint field in PR #110

merged 11 commits into from
Nov 9, 2022

Conversation

ronaudinho
Copy link
Contributor

Closes #45 .

Currently checks if Sprint field is set to current one if exists, not sure if necessary, as depending on implementation plan for #53, may be checking only if the title matches would suffice?

Checks for current sprint based on start date and duration of iteration, reporting it in a custom field named `{IterationName}/IsCurrent` with Y/N.

`main_test` might have to be updated later as it will probably fail when a PR is made outside of current sprint period. This may not be necessary, depending on implementation of another issue.
For cases where "Sprint" field exists but not set, none is returned in projectFieldValue, hence it is necessary to check in projectField if there is any IterationField at all.
internal/graphql/pull_request_test.go Outdated Show resolved Hide resolved
internal/graphql/pull_request_test.go Outdated Show resolved Hide resolved
@AlekSi AlekSi added the trust PRs that can access Actions secrets label Oct 26, 2022
@AlekSi AlekSi requested a review from chilagrow October 26, 2022 12:13
@AlekSi AlekSi self-requested a review October 27, 2022 15:14
conform-pr/main.go Outdated Show resolved Hide resolved
conform-pr/main_test.go Outdated Show resolved Hide resolved
internal/graphql/pull_request.go Outdated Show resolved Hide resolved
@AlekSi AlekSi enabled auto-merge (squash) November 9, 2022 05:39
@AlekSi AlekSi disabled auto-merge November 9, 2022 05:41
@AlekSi AlekSi merged commit 860b0b5 into FerretDB:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trust PRs that can access Actions secrets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Sprint field in PRs
2 participants