Add tests for decimal128 and timestamp
#78
Conversation
There was a problem hiding this comment.
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 63.04% 63.14% +0.09%
==========================================
Files 41 41
Lines 2395 2401 +6
==========================================
+ Hits 1510 1516 +6
Misses 701 701
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (2)
- go.mod: Language not supported
- wirebson/bson.go: Evaluated as low risk
Comments suppressed due to low confidence (1)
wirebson/logging.go:338
- [nitpick] The variable name 'H' is ambiguous. It should be renamed to 'High' for better readability.
b.WriteString("Decimal128(H:")
AlekSi
changed the title
decimal128decimal128 and timestamp
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- go.mod: Language not supported
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
wireclient/wireclient_test.go:216
- The placeholder for the
Timestamptest should be completed or removed.
t.Run("Timestamp", func(t *testing.T) { // FIXME })
There was a problem hiding this comment.
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (2)
- go.mod: Language not supported
- tools/go.mod: Language not supported
Comments suppressed due to low confidence (2)
wireclient/wireclient_test.go:211
- Consider adding test cases for edge values of 'time' and 'increment' in the 'Timestamp' tests to ensure robustness.
t.Run("Timestamp", func(t *testing.T) {
wirebson/bson_test.go:1303
- The comment on the t.Skip line should provide more context about why the test is being skipped.
t.Skip("https://github.com/FerretDB/wire/issues/49")
No description provided.