Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with FerretDB v2 #83

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Test with FerretDB v2 #83

merged 2 commits into from
Jan 30, 2025

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jan 30, 2025

No description provided.

@AlekSi AlekSi requested a review from Copilot January 30, 2025 11:40
@mergify mergify bot assigned AlekSi Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • .dev/ferretdb1.Dockerfile: Language not supported
  • .dev/ferretdb2.Dockerfile: Language not supported
  • .dev/postgres.Dockerfile: Language not supported
Comments suppressed due to low confidence (2)

wireclient/wireclient_test.go:81

  • The removal of the InvalidDatabase test case reduces test coverage for invalid database scenarios. Please ensure that invalid database scenarios are still covered by other tests.
t.Run("InvalidDatabase", func(t *testing.T) {

.dev/docker-compose.yml:25

  • The POSTGRES_DB variable is commented out, but the FERRETDB_POSTGRESQL_URL still references it. This could cause confusion or errors if uncommented.
# POSTGRES_DB: postgres
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.93%. Comparing base (5318440) to head (55fddef).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   63.39%   62.93%   -0.46%     
==========================================
  Files          41       41              
  Lines        2396     2396              
==========================================
- Hits         1519     1508      -11     
- Misses        694      702       +8     
- Partials      183      186       +3     

see 2 files with indirect coverage changes

Flag Coverage Δ
test 62.93% <ø> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested a review from Copilot January 30, 2025 11:42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • .dev/ferretdb1.Dockerfile: Language not supported
  • .dev/ferretdb2.Dockerfile: Language not supported
  • .dev/postgres.Dockerfile: Language not supported
Comments suppressed due to low confidence (1)

wireclient/wireclient_test.go:79

  • The removal of the 'InvalidDatabase' test case results in a lack of test coverage for invalid database login attempts. Please ensure this behavior is covered by other tests or reintroduce this test case.
t.Run("InvalidDatabase", func(t *testing.T) {
@AlekSi AlekSi marked this pull request as ready for review January 30, 2025 11:53
@AlekSi AlekSi merged commit dac2dab into FerretDB:main Jan 30, 2025
9 checks passed
@AlekSi AlekSi deleted the ferretdb2 branch January 30, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant