Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize interpolation testing #1136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

KnutAM
Copy link
Member

@KnutAM KnutAM commented Jan 27, 2025

This PR includes some modularization of the testing of interpolations started in #798, and is the first breakout from that PR.

Specifically all tests that every base interpolations should pass should be put into test_interpolation_properties(ip::Interpolation). Having such a function was very valuable when developing the interpolations in #798, and it also makes it easier to include it in testing of such exotic interpolations when all assumptions currently tested for scalar and nodal interpolations don't hold.

It also separates testing of the reference shapes from the testing of the interpolations, and fixes one discovered issue with the thrown error from reference_shape_value(ip::DiscontinuousLagrange{shape, 0}, ... (it silently accepted i > n_basefunctions)

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.30%. Comparing base (951ec47) to head (8d1807a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
- Coverage   93.57%   93.30%   -0.28%     
==========================================
  Files          39       39              
  Lines        6073     6106      +33     
==========================================
+ Hits         5683     5697      +14     
- Misses        390      409      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@termi-official termi-official self-requested a review January 27, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant