Modularize interpolation testing #1136
Open
+288
−192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some modularization of the testing of interpolations started in #798, and is the first breakout from that PR.
Specifically all tests that every base interpolations should pass should be put into
test_interpolation_properties(ip::Interpolation)
. Having such a function was very valuable when developing the interpolations in #798, and it also makes it easier to include it in testing of such exotic interpolations when all assumptions currently tested for scalar and nodal interpolations don't hold.It also separates testing of the reference shapes from the testing of the interpolations, and fixes one discovered issue with the thrown error from
reference_shape_value(ip::DiscontinuousLagrange{shape, 0}, ...
(it silently acceptedi > n_basefunctions
)