Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmarks #855

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

AbdAlazezAhmed
Copy link
Collaborator

@AbdAlazezAhmed AbdAlazezAhmed commented Dec 6, 2023

Updates benchmarks after the changes in #764 to work with master
Changes:

  • Using FaceValues{<: Ferrite.FunctionValues{_, <: Ferrite.InterpolationByDim{dim}} to dispatch over dim removed dim
  • get_coordinate_type(grid) is not exported

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53f5ba1) 92.41% compared to head (b4c3226) 92.09%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
- Coverage   92.41%   92.09%   -0.33%     
==========================================
  Files          36       36              
  Lines        5223     5223              
==========================================
- Hits         4827     4810      -17     
- Misses        396      413      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbdAlazezAhmed AbdAlazezAhmed added the awaiting review PR is finished from the authors POV, waiting for feedback label Dec 6, 2023
@termi-official termi-official self-requested a review December 6, 2023 18:38
@termi-official termi-official merged commit 6f37665 into Ferrite-FEM:master Dec 7, 2023
@AbdAlazezAhmed AbdAlazezAhmed removed the awaiting review PR is finished from the authors POV, waiting for feedback label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants