Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix patch #801

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

Hotfix patch #801

wants to merge 43 commits into from

Conversation

novoj
Copy link
Collaborator

@novoj novoj commented Feb 11, 2025

novoj and others added 30 commits February 6, 2025 09:54
…unction-might-be-legally-empty

fix: cannot use facetXXXGroupsXXX for reference without group type (i.e. with no parameters)
In traffic recording updates the labels were added to JFR events and this way they also got into the observability metrics. This made metrics with very high cardinality and overloads the server. We need to reconsider the approach to labels that get incorporated into the metrics.

Refs: #800
novoj added 13 commits February 11, 2025 15:22
In following scenario:

- Entity `category` refers `product` by reflected reference of cardinality zero or more and inherited attributes
- Entity `product` refers `category` by standard reference with attribute `variant` with cardinality zero or more

When product is created and contains two refrences:

1. category PK=1 and variant = `false`
2. category PK=2 and variant = `true`

The category with PK = 1 contains reflected reference to product with variant attribute set to `true` instead of false. It's because there are implicit attribute mutations by product for category with PK retrieved from all references to this entity type, so that there is:

1. upsertAttributeMutation: vairant = `false`
2. upsertAttributeMutation: vairant = `true`

And the latter overwrites the former. Correctly there should be only single attribute mutation that correctly targets category with PK = 1.

Refs: #803
(cherry picked from commit d781ec4)
In traffic recording updates the labels were added to JFR events and this way they also got into the observability metrics. This made metrics with very high cardinality and overloads the server. We need to reconsider the approach to labels that get incorporated into the metrics.

Refs: #800
(cherry picked from commit 01a62f3)
…cope of the entity

When entity is transferred between scopes (ie. ARCHIVED <-> LIVE) the references in facet index lose information about facet group assignment.

Refs: #814
(cherry picked from commit 337b193)
…nd cannot be filtered by. Filtering by without index would be slow.

Error was incorrectly issued when engine fails to find non existing index in correctly indexed scope.

Ref: #815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants