-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix patch #801
Open
novoj
wants to merge
43
commits into
master
Choose a base branch
from
master-hotfix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hotfix patch #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2ae764f)
….e. with no parameters) Refs: #798
…unction-might-be-legally-empty fix: cannot use facetXXXGroupsXXX for reference without group type (i.e. with no parameters)
In traffic recording updates the labels were added to JFR events and this way they also got into the observability metrics. This made metrics with very high cardinality and overloads the server. We need to reconsider the approach to labels that get incorporated into the metrics. Refs: #800
In following scenario: - Entity `category` refers `product` by reflected reference of cardinality zero or more and inherited attributes - Entity `product` refers `category` by standard reference with attribute `variant` with cardinality zero or more When product is created and contains two refrences: 1. category PK=1 and variant = `false` 2. category PK=2 and variant = `true` The category with PK = 1 contains reflected reference to product with variant attribute set to `true` instead of false. It's because there are implicit attribute mutations by product for category with PK retrieved from all references to this entity type, so that there is: 1. upsertAttributeMutation: vairant = `false` 2. upsertAttributeMutation: vairant = `true` And the latter overwrites the former. Correctly there should be only single attribute mutation that correctly targets category with PK = 1. Refs: #803 (cherry picked from commit d781ec4)
In traffic recording updates the labels were added to JFR events and this way they also got into the observability metrics. This made metrics with very high cardinality and overloads the server. We need to reconsider the approach to labels that get incorporated into the metrics. Refs: #800 (cherry picked from commit 01a62f3)
…nd cannot be filtered by. Filtering by without index would be slow. Error was incorrectly issued when engine fails to find non existing index in correctly indexed scope. Ref: #815
# Conflicts: # pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facetGroupsConjunction
might be legally empty #798): ConstraintfacetGroupsConjunction
might be legally empty