Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Django 4.2 support #2

Merged
merged 43 commits into from
Mar 27, 2024
Merged

Feat: Django 4.2 support #2

merged 43 commits into from
Mar 27, 2024

Conversation

joshyu
Copy link
Member

@joshyu joshyu commented Mar 20, 2024

Description

Describe:

  • Content of the pull request
  • Feature added / Problem fixed

References

Provide any github issue fixed (as in Fix #XYZ)

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

vipulnarang95 and others added 30 commits May 12, 2020 17:58
* Update compatible with Django CMS version4

sitemap.py and cms_toolbars.py updated to support page menu and sitemap compatible with Django CMS version 4


Co-authored-by: Vipul, Narang <[email protected]>
…ms4 (nephila#58)

* Updated lastmod() to return latest publish version modified date if versioning is enabled.



Co-authored-by: narender81 <[email protected]>
* Use the page toolbar from the CMS as this doesn't add more buttons. It's also designed fro use just on the page too

* Functioning toolbar with versioning enabled

* Added versioning test to ensure that the toolbar duplicated button issue never occurs again

* Remove limit on versioning being installed. The test suite should run the same regardless of versioning
* Add filter to list only published pages in versioning is enabled/installed
* Add test to check query performance

Co-authored-by: narender81 <[email protected]>
@coveralls
Copy link

coveralls commented Mar 20, 2024

Pull Request Test Coverage Report for Build 8361004104

Details

  • 33 of 44 (75.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-6.5%) to 93.506%

Changes Missing Coverage Covered Lines Changed/Added Lines %
djangocms_page_sitemap/utils.py 6 9 66.67%
djangocms_page_sitemap/sitemap.py 20 28 71.43%
Totals Coverage Status
Change from base Build 8345190632: -6.5%
Covered Lines: 175
Relevant Lines: 186

💛 - Coveralls

@joshyu joshyu changed the title Feat: issue 82 djangocms 4 Feat: Django 4.2 support Mar 20, 2024
@joshyu joshyu merged commit 3dd4ffb into develop Mar 27, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants