Merge pull request #93 from vipulnarang95/bugfix/pageadmin-edit-close…

…-side-frame Fix editlink in pageadmin to close sideframe
FidelityInternational · Jun 6, 2024 · e689dbc · e689dbc
2 parents e340b2d + 6429474
commit e689dbc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -2,6 +2,9 @@
 Changelog
 =========
 
+Unreleased
+=================
+* Fixed edit link in pageadmin to close sideframe
 
 1.7.0 (2024-05-16)
 ==================

diff --git a/djangocms_pageadmin/admin.py b/djangocms_pageadmin/admin.py
@@ -260,9 +260,10 @@ def _get_edit_link(self, obj, request, disabled=False):
             args=(version.pk,),
         )
 
+        # close sideframe as edit will always be on page and not in sideframe
         return render_to_string(
             "djangocms_pageadmin/admin/icons/edit.html",
-            {"url": url, "disabled": disabled, "get": False},
+            {"url": url, "disabled": disabled, "get": False, "keepsideframe": False},
         )
 
     def _get_duplicate_link(self, obj, request, disabled=False):