Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-32565] Repo setup #1

Merged
merged 28 commits into from
Jan 24, 2024
Merged

[sc-32565] Repo setup #1

merged 28 commits into from
Jan 24, 2024

Conversation

nrutman
Copy link
Contributor

@nrutman nrutman commented Jan 18, 2024

This PR fulfills the first task on SC-32565. It moves the pipeline code to its own repository.

Copy link
Contributor

@namoscato namoscato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited we're shipping this!

I reviewed all of the ancillary configuration files and will glance through the code / read through documentation in the next pass.

.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link

This pull request has been linked to Shortcut Story #32565: Publish Pipeline package.

@nrutman
Copy link
Contributor Author

nrutman commented Jan 19, 2024

This pull request has been linked to Shortcut Story #32565: Publish Pipeline package.

I saw that Shortcut didn't automatically link this when I created the PR. @namoscato how did you set this up?

@nrutman nrutman requested a review from namoscato January 19, 2024 13:25
@nrutman

This comment was marked as resolved.

@nrutman
Copy link
Contributor Author

nrutman commented Jan 19, 2024

@namoscato one other question with a package planned for public consumption: is there a way to automatically build the JS so that it could be used as a JS package too? Or would we have to commit /build to the repo and remember to build it every time?

Copy link
Contributor

@namoscato namoscato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed up a few loose end configuration commits.

Documentation looks great, and I just have one outstanding question on the code.

I saw that Shortcut didn't automatically link this when I created the PR. @namoscato how did you set this up?

I didn't do anything – maybe Shortcut just needed another webhook.

src/buildPipeline.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@nrutman

This comment was marked as resolved.

@nrutman nrutman requested a review from namoscato January 22, 2024 15:34
@nrutman

This comment was marked as resolved.

Copy link
Contributor

@namoscato namoscato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nrutman nrutman merged commit ffc9506 into main Jan 24, 2024
1 check passed
@nrutman nrutman deleted the repo-setup branch January 24, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants