Feature/post tab bar ui

[ethanswift]

What this PR does:
Creates a tab bar UI for tab bar controller

Checklist

• Compiler warnings resolved
• Linter warnings resolved
• User-facing strings in Localizable.strings file
• Unused code, print statements, and comments removed

Which issue(s) this PR fixes:

Resolves #
Implementing TabBar UI with a function that takes one bar item as parameter and return it as selected.

Special notes for reviewers:

Additional comments:

[stavares843]

when compiling, still shows the previous tab bar

https://jmp.sh/A2ynhc5

[ethanswift]

when compiling, still shows the previous tab bar

https://jmp.sh/A2ynhc5

Well I've deleted the testing code. for compiling you should put it in a view

[stavares843]

great, thanks

just confirming if was implemented

[ethanswift]

great, thanks

just confirming if was implemented

Last try, it worked and I took that image, and it's working on Travis CI, but don't know about other devices.

I can add a testing code if you think its necessary.

[hkellaway]

let's organize this under Features/TabBar instead of Features/Post/CreatePost

[hkellaway]

can we call this TabBar instead of TabBarUI? no need to include UI in the name of a UI component

[ethanswift]

@ethanswift i think maybe the requirements have been lost in translation? this Issue covers replacing the tab bar of the entire app

so what i would imagine is, instead of subclassing UIView, you'd be subclassing UITabBar. and you'd have to work in RootTabBarController to customize its tabBar property

i didnt have the chance to look at your component closely - but reading it its seems as though perhaps the dotView is statically placed under the Home tab icon. the intention is for each tab to have a selected and a deselected state; in the selected state, a dot appears under the icon in place of the title

if getting the dot aspect in is a lot, i'd say its acceptable to drop the dot bit and just concern yourself with replacing the tab bar

Actually, its instance method is getting a selected enum which asks for the tab which is selected as a parameter and adds that dot and bolden that image (make it black). so in the function which is setUp(selected: .feed) you choose which tab to be loaded

[hkellaway]

@ethanswift i think maybe the requirements have been lost in translation? this Issue covers replacing the tab bar of the entire app

so what i would imagine is, instead of subclassing UIView, you'd be subclassing UITabBar. and you'd have to work in RootTabBarController to customize its tabBar property

i didnt have the chance to look at your component closely - but reading it its seems as though perhaps the dotView is statically placed under the Home tab icon. the intention is for each tab to have a selected and a deselected state; in the selected state, a dot appears under the icon in place of the title

if getting the dot aspect in is a lot, i'd say its acceptable to drop the dot bit and just concern yourself with replacing the tab bar

[ethanswift]

@ethanswift i think maybe the requirements have been lost in translation? this Issue covers replacing the tab bar of the entire app

so what i would imagine is, instead of subclassing UIView, you'd be subclassing UITabBar. and you'd have to work in RootTabBarController to customize its tabBar property

i didnt have the chance to look at your component closely - but reading it its seems as though perhaps the dotView is statically placed under the Home tab icon. the intention is for each tab to have a selected and a deselected state; in the selected state, a dot appears under the icon in place of the title

if getting the dot aspect in is a lot, i'd say its acceptable to drop the dot bit and just concern yourself with replacing the tab bar

Actually, its instance method is getting a selected enum which asks for the tab which is selected as a parameter and adds that dot and bolden that image (make it black). so in the function which is setUp(selected: .feed) you choose which tab to be loaded

[ethanswift]

@ethanswift i think maybe the requirements have been lost in translation? this Issue covers replacing the tab bar of the entire app

so what i would imagine is, instead of subclassing UIView, you'd be subclassing UITabBar. and you'd have to work in RootTabBarController to customize its tabBar property

i didnt have the chance to look at your component closely - but reading it its seems as though perhaps the dotView is statically placed under the Home tab icon. the intention is for each tab to have a selected and a deselected state; in the selected state, a dot appears under the icon in place of the title

if getting the dot aspect in is a lot, i'd say its acceptable to drop the dot bit and just concern yourself with replacing the tab bar

Also for the tab bar you can add the view if necessary, if not we can work on adding the code inside tab bar controller

[hkellaway]

Also for the tab bar you can add the view if necessary, if not we can work on adding the code inside tab bar controller

let's replace the tab bar in this PR if youre good to go !

[ethanswift]

Also for the tab bar you can add the view if necessary, if not we can work on adding the code inside tab bar controller

let's replace the tab bar in this PR if youre good to go !

sure

[stavares843]

I can add a testing code if you think its necessary.

no need, thanks @ethanswift

[ethanswift]

Also for the tab bar you can add the view if necessary, if not we can work on adding the code inside tab bar controller

let's replace the tab bar in this PR if youre good to go !

you mean changing class name to TabBar?