Remove configuration caching from createAndPushVersionTag task (#88)

FigureTechnologies · Mar 23, 2023 · 416f195 · 416f195
1 parent e74863f
commit 416f195
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 46 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -1,5 +1,7 @@
 import org.gradle.api.tasks.testing.logging.TestExceptionFormat
 import org.gradle.api.tasks.testing.logging.TestLogEvent
+import org.jetbrains.kotlin.gradle.dsl.JvmTarget
+import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
 import org.jetbrains.kotlin.config.KotlinCompilerVersion.VERSION as KOTLIN_VERSION
 
 @Suppress("DSL_SCOPE_VIOLATION")
@@ -67,16 +69,18 @@ configurations.all {
 }
 
 kotlin {
-    // Configures Java toolchain both for Kotlin JVM and Java tasks
     jvmToolchain(11)
-    target {
-        compilations.all {
-            kotlinOptions {
-                freeCompilerArgs =
-                    freeCompilerArgs + listOf("-version", "-Xjsr305=strict", "-opt-in=kotlin.RequiresOptIn")
-                verbose = true
-            }
-        }
+}
+
+tasks.withType<KotlinCompile>().configureEach {
+    compilerOptions {
+        jvmTarget.set(JvmTarget.JVM_11)
+        freeCompilerArgs.addAll(
+            "-version",
+            "-Xjsr305=strict",
+            "-opt-in=kotlin.RequiresOptIn"
+        )
+        verbose.set(true)
     }
 }
 

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -5,7 +5,7 @@ kotlin = "1.8.10"
 # Library versions
 detekt = "1.22.0"
 gradle-plugin-publish = "1.1.0"
-jgit = "6.4.0.202211300538-r"
+jgit = "6.5.0.202303070854-r"
 kotest = "5.5.5"
 ktlint-gradle = "11.3.1"
 swiftzer-semver = "1.2.0"

diff --git a/src/main/kotlin/com/figure/gradle/semver/SemverPlugin.kt b/src/main/kotlin/com/figure/gradle/semver/SemverPlugin.kt
@@ -8,9 +8,10 @@
 package com.figure.gradle.semver
 
 import com.figure.gradle.semver.internal.git.git
-import com.figure.gradle.semver.internal.tasks.CreateAndPushVersionTag
+import com.figure.gradle.semver.internal.semverLifecycle
 import com.figure.gradle.semver.internal.tasks.CurrentSemverTask
 import com.figure.gradle.semver.internal.tasks.GenerateVersionFileTask
+import org.gradle.api.DefaultTask
 import org.gradle.api.Plugin
 import org.gradle.api.Project
 import org.gradle.kotlin.dsl.create
@@ -40,9 +41,13 @@ class SemverPlugin : Plugin<Project> {
             versionTagName.set(semver.versionTagName)
         }
 
-        project.tasks.register<CreateAndPushVersionTag>("createAndPushVersionTag") {
-            versionTagName.set(semver.versionTagName)
-            git.set(project.git(semver.gitDir.get()))
+        // Just run this task. This avoids a whole headache with configuration caching.
+        // This task should never be cached so there is no reason to involve caching mechanisms
+        project.tasks.register<DefaultTask>("createAndPushVersionTag") {
+            val git = project.git(semver.gitDir.get())
+            git.tag().setName(semver.versionTagName).call()
+            git.push().setPushTags().call()
+            logger.semverLifecycle("Created and pushed version tag: ${semver.versionTagName}")
         }
     }
 }
diff --git a/src/main/kotlin/com/figure/gradle/semver/internal/tasks/CreateAndPushVersionTag.kt b/src/main/kotlin/com/figure/gradle/semver/internal/tasks/CreateAndPushVersionTag.kt