[FLINK-26570][statefun] Remote module configuration interpolation #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilKarnicki
force-pushed
the
FLINK-26570_remote_module_configuration_interpolation_final
branch
2 times, most recently
from
b8b30d1 to
fd50425
Compare
FilKarnicki
force-pushed
the
FLINK-26570_remote_module_configuration_interpolation_final
branch
2 times, most recently
from
71a001e to
dedb0f3
Compare
...flink-extensions/src/main/java/org/apache/flink/statefun/extensions/ComponentJsonObject.java
Show resolved
Hide resolved
...ink-core/src/test/java/org/apache/flink/statefun/flink/core/jsonmodule/RemoteModuleTest.java
Show resolved
Hide resolved
|
[Major] I couldn't find a test that confirms the correct order of merging the config sources. A test that checks if comand line parameters override env variables, for instance. Did I missed this test? |
|
[Major] I'm wondering what's the behior of the feature when the config value for the placeholder is missing. Do we ignore it? Do we throw an exception? |
FilKarnicki
force-pushed
the
FLINK-26570_remote_module_configuration_interpolation_final
branch
2 times, most recently
from
125907c to
992aef9
Compare
Owner
Author
Now we throw. Thanks. |
FilKarnicki
force-pushed
the
FLINK-26570_remote_module_configuration_interpolation_final
branch
3 times, most recently
from
61f4e5d to
3d3ff6f
Compare
FilKarnicki
force-pushed
the
FLINK-26570_remote_module_configuration_interpolation_final
branch
from
3d3ff6f to
4f63228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.