Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update interface #78

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Update interface #78

merged 5 commits into from
Dec 3, 2024

Conversation

ZenGround0
Copy link
Contributor

Closes #56 giving PDPService implementations the option to do client-signs-sp-submits protocols as in today's builtin storage market.

Will take out of draft once the challenge window PR upon which this is based is merged

anorth
anorth approved these changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding at least one test that the extra data makes it through to the application/service, even though it looks straightforward and is largely constrained by types.

Otherwise LGTM

src/PDPVerifier.sol Show resolved Hide resolved
src/PDPVerifier.sol Outdated Show resolved Hide resolved
@aarshkshah1992 aarshkshah1992 changed the base branch from feat/challenge-window-refactor to main December 3, 2024 10:26
@aarshkshah1992 aarshkshah1992 marked this pull request as ready for review December 3, 2024 10:53
@ZenGround0 ZenGround0 merged commit ef3976d into main Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anorth anorth anorth approved these changes

@aarshkshah1992 aarshkshah1992 aarshkshah1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDP Methods should take in extra data
3 participants
@ZenGround0 @anorth @aarshkshah1992