Scripts and unit tests for contract upgrade and ownership transfer #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am now testing ownership/upgrade with a multisig. |
ZenGround0
force-pushed
the
feat/upgrade-test-scripts
branch
from
2907cca to
f487ecf
Compare
ZenGround0
reviewed
Jan 13, 2025
| ##################################### | ||
|
|
||
| : "${FIL_CALIBNET_RPC_URL:?FIL_CALIBNET_RPC_URL not set. Please export it and rerun.}" | ||
| : "${FIL_CALIBNET_PRIVATE_KEY:?FIL_CALIBNET_PRIVATE_KEY not set. Please export it and rerun.}" |
There was a problem hiding this comment.
Purely out of curiosity how do you get your private keys? In the past I've ended up needing to write my own script to extract from eth keystore since that design works hard to avoid extraction.
ZenGround0
reviewed
Jan 13, 2025
| ) | ||
|
|
||
| # Extract the deployed address from JSON output | ||
| PDP_VERIFIER_ADDRESS=$(echo "$DEPLOY_OUTPUT_VERIFIER" | jq -r '.deployedTo') |
There was a problem hiding this comment.
I'm having trouble parsing this on both OSX and linux. There is no deployedTo field in my output json. Have you gotten it working since making this change?
ZenGround0
force-pushed
the
feat/upgrade-test-scripts
branch
from
09ba0a4 to
ccab75e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ZenGround0
Manually tested
_authorizeUpgradefunction in the upgradedPDPVerifiercontract always revert.This PR has unit tests for testing contract upgrade and ownership transfer and also scripts to do it all on calibnet.