Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Show recording devices in UI #1592

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ViktorShapoval
Copy link

Add 2 new community settings that will allow users to see and interact with recording devices in Context menu and Flyout window.

That is very useful for users who have to switch recording device based on what playback device they are using.
Example: switching between headphones with integrated microphone and earphones with separate microphone device.
Switching in such cases is painful using default Windows UI so EarTrumpet can help alot here.

Changes in UI are only visible when settings toggled on. Without them UI stays as before this PR.

Screenshots with new UI are below. I'm not very satisfied with how Switch to Recording/Playback buttons look and placed so suggestions are welcome here.

Screenshot 2024-08-27 183214

Screenshot 2024-08-27 183257

Screenshot 2024-08-27 183308

Screenshot 2024-08-27 183319

Screenshot 2024-08-27 183333

Screenshot 2024-08-27 183347

Add community settings that will allow users to see and interact with
recording devices in Context menu and Flyout window.

That is very useful for users who have to switch recording device based
on what playback device they are using.
Example: switching between headphones with integrated microphone and
earphones with separate microphone device.
Switching in such cases is painful using default Windows UI so
EarTrumpet can help alot here.
@CLAassistant
Copy link

CLAassistant commented Aug 27, 2024

CLA assistant check
All committers have signed the CLA.

@Gillwindy
Copy link

Gillwindy commented Sep 5, 2024

Hey, I think you might want to read Contributing to EarTrumpet for your feature to merge?
I actually found your feature to be really useful for me, so I'm quite looking forward for this to be included.

@ViktorShapoval
Copy link
Author

Hey, I think you might want to read Contributing to EarTrumpet for your feature to merge? I actually found your feature to be really useful for me, so I'm quite looking forward for this to be included.

Hi, and thanks for the feedback. As for now, I don't have clear answer from EarTrumpet maintainers whether they agree or not to include such functionality in the project.
If you don't want to wait - you can take my branch and build it with Release target yourself with free version of visual studio.

@riverar
Copy link
Contributor

riverar commented Sep 5, 2024

I'm not opposed to this, and like the idea of adding this as a community feature, but I'm nearing the end of a major migration to .NET 8+ and new pipelines, of which this will conflict. We also have an add-on framework in the app which would probably be better suited for this. (We currently have a private repository for some in-house unreleased add-ons and managing recording devices is one of them.)

Hmm, let me think about how we want to handle this. Standby!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants