groupings to replace children #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s12chung
changed the title
| file = CsvRowModel::Import::File.new(file_path, GroupedColumnImportModel) | ||
| file.next.attributes # => { names: ['abbey'], standard: '', tags: ['a', b'] } | ||
| file.next.attributes # => { names: ['bob'], standard: 'not_empty', tags: ['c'] } # does not group 'chris' because the `standard` cell is not empty | ||
| file.next.attributes # => { names: ['chris', 'dave'], standard: 'not_empty', tags: ['d', 'e'] } |
There was a problem hiding this comment.
Really weird case..... I don't see any case like that and our CSVs
There was a problem hiding this comment.
library :p (we're trying to replace children)
|
What about validations on those fields? |
|
@joel validations are the same really, they just apply to the array |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal because the children code is kinda confusing. and we have a hack: https://github.com/FinalCAD/finalcloud/blob/e2ba5e9a1727483dd86811e4865e0e733123df26/build/core/row_models/export/library_export_row.rb#L14-L21
making this feature made me think of having a
Columnclass that represents each column instead of holding hashes. only an idea, sinceimport/attributesis becoming a bit messy.