Don't run review jobs on tagged releases on next #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivomurrell
force-pushed
the
next-circleci-skip-review-jobs
branch
from
26466f8
to
3e2970e
Compare
ivomurrell
force-pushed
the
next-circleci-skip-review-jobs
branch
from
3e2970e
to
3c11173
Compare
apaleslimghost
approved these changes
Sep 10, 2024
Port of 35a24dc, original description follows: We are already running staging jobs on tagged releases, so we don't need to run review jobs too. In addition, the HerokuReview task will fail as it can't find a branch to associate the review app with.
ivomurrell
force-pushed
the
next-circleci-skip-review-jobs
branch
from
3c11173
to
f373212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port of #669 to
next. From the original PR's description:Checklist:
feat(circleci): add support for nightly workflows,fix: set Heroku app name for staging apps too