make tool kit config loading agnostic of CWD #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaleslimghost
force-pushed
the
roots-manuva
branch
from
53f2298
to
e90de8b
Compare
apaleslimghost
force-pushed
the
roots-manuva
branch
from
85ada6c
to
f23e8d1
Compare
apaleslimghost
changed the title
…t uses process.cwd
apaleslimghost
force-pushed
the
roots-manuva
branch
from
ae6b2f2
to
076adff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool Kit currently implicitly uses
process.cwd()in a lot of places in its config loading and tasks. this makes monorepo support more difficult, as we'll want to be loading configs and running tasks in directories that are not the current shell working directory (i.e. within monorepo workspace packages). while the monorepo plugin could do someprocess.chdir()shenanigans, i'd like to avoid that as keeping the state consistent and concurrency-safe will be very very difficult.this PR refactors Tool Kit internals to specify exactly where to load configs from, and keep track of that using the
config.rootproperty. this property was previously set to the directory of theclipackage for reasons i don't understand, and was never actually being used, so it's safe to repurpose for this.it also passes through the
cwdin the newishTaskRunContextargument forTask.runso tasks can use that to be aware of which directory to run in, and (hopefully) as much as possible uses thatcwdin our existing tasks. while i'm at it it adds the currentcommandtoTaskRunContextfor use by the monorepo plugin.this PR was split from #630 so they can both be reviewed more easily.