Removes jsHint in favour of ESLint. Adds Babel-Runtime polyfill and t…

.eslintrc

@@ -0,0 +1,29 @@
+{
+    "env": {
+        "node": true,
+        "es6": true
+    },
+    "ecmaFeatures": {
+        "modules": false
+    },
+    "rules": {
+        "no-unused-vars": 2,
+        "no-undef": 2,
+        "eqeqeq": 2,
+        "no-underscore-dangle": 0,
+        "guard-for-in": 2,
+        "no-extend-native": 2,
+        "wrap-iife": 2,
+        "new-cap": 2,
+        "no-caller": 2,
+        "strict": [2, "global"],
+        "quotes": [1, "single"],
+        "no-loop-func": 2,
+        "no-irregular-whitespace": 1,
+        "no-multi-spaces": 2,
+        "one-var": [2, "never"]
+    },
+    "globals": {
+        "fetch": true
+    }
+}

.npmignore

@@ -1,6 +1,5 @@
 .idea/
 test/
 *.md
-.jshintrc
 gulpfile.js
 .travis.yml

README.md

@@ -56,7 +56,7 @@ All the tasks are built using [gulp](http://gulpjs.com/), and almost all of them
 	   [--buildCss=<file>]          Compiled CSS file (default: main.css)
 	   [--buildFolder=<dir>]        Compiled assets directory (default: ./build/)
 	   [--scssLintPath=<path>]      Custom scss-lint configuration
-	   [--jsHintPath=<path>]        Custom JSHint configuration
+	   [--esLintPath=<path>]        Custom esLint configuration
 	   [--editorconfigPath=<path>]  Custom .editorconfig
 
 ### `install`
@@ -145,8 +145,8 @@ Runs:
 * __scssLint(gulp, config)__ Config accepts:
 	- scssLintPath: `String` Path to your custom 'scss-lint.yml' config file. (Default: 'origami-build-tools/config/scss-lint.yml') _This may be set for product development, but developers of Origami-compliant components are required to accept the default_
 	- excludeFiles `Array` e.g. `['!**/demo.scss']`
-* __jsHint(gulp, config)__ Config accepts:
-	- jsHintPath: `String` Path to your custom jsHint config file. (Default: 'origami-build-tools/config/jshint.json' _This may be set for product development, but developers of Origami-compliant components are required to accept the default_
+* __esLint(gulp, config)__ Config accepts:
+	- esLintPath: `String` Path to your custom esLint config file. (Default: 'origami-build-tools/config/.eslintrc' _This may be set for product development, but developers of Origami-compliant components are required to accept the default_
 	- excludeFiles `Array` e.g. `['!**/demo.js']`
 * __lintspaces(gulp, config)__ Config accepts:
 	- editorconfigPath: `String` Path to your '.editorconfig' that lintspaces uses for linting. (Default: 'origami-build-tools/config/.editorconfig') _This may be set for product development, but developers of Origami-compliant components are required to accept the default_

config/.eslintrc

@@ -0,0 +1,37 @@
+{
+	"ecmaFeatures": {
+		"modules": true
+	},
+	"env": {
+		"es6": true,
+		"browser": true
+	},
+	"rules": {
+		"no-unused-vars": 2,
+		"no-undef": 2,
+		"eqeqeq": 2,
+		"guard-for-in": 2,
+		"no-extend-native": 2,
+		"wrap-iife": 2,
+		"new-cap": 2,
+		"no-caller": 2,
+		"no-multi-str": 0,
+		"dot-notation": 0,
+		"strict": [2, "global"],
+		"valid-jsdoc": 1,
+		"no-irregular-whitespace": 1,
+		"no-multi-spaces": 2,
+		"one-var": [2, "never"],
+		"constructor-super": 2,
+		"no-this-before-super": 2,
+		"no-var": 2,
+		"prefer-const": 1,
+		"no-const-assign": 2
+	},
+	"globals": {
+		"require": false,
+		"module": false,
+		"exports": false,
+		"requireText": false
+	}
+}

gulpfile.js

@@ -5,7 +5,7 @@ var obt = require('./lib/origami-build-tools');
 
 gulp.task('verify', function() {
 	return obt.verify(gulp, {
-		jsHintPath: '.jshintrc',
+		esLintPath: '.eslintrc',
 		editorconfigPath: '.editorconfig'
 	});
 });

lib/helpers/command-line.js

@@ -3,13 +3,13 @@
 var childProcess = require('child_process');
 var which = require('which');
 var log = require('./log');
-var windows = (process.platform.indexOf("win32") >= 0 || process.platform.indexOf("win64") >= 0);
+var windows = (process.platform.indexOf('win32') >= 0 || process.platform.indexOf('win64') >= 0);
 
 function run(command, args, options) {
 	return new Promise(function(resolve, reject) {
-		var pro,
-			stdOut = "",
-			stdErr = "";
+		var pro;
+		var stdOut = '';
+		var stdErr = '';
 
 		if (windows) {
 			args.unshift('/c', command);
@@ -31,7 +31,7 @@ function run(command, args, options) {
 		});
 
 		pro.on('close', function(code) {
-			var output = { "stderr": stdErr, "stdout": stdOut };
+			var output = { 'stderr': stdErr, 'stdout': stdOut };
 
 			if (code !== 0) {
 				output.err = code;

lib/helpers/files.js

@@ -10,6 +10,30 @@ function getBuildFolderPath() {
 	return path.join(process.cwd(), '/build/');
 }
 
+function requireIfExists(filePath) {
+	if (fs.existsSync(filePath)) {
+		return require(filePath);
+	} else {
+		return undefined;
+	}
+}
+
+function getPackageJson() {
+	return requireIfExists(path.join(process.cwd(), '/package.json'));
+}
+
+function packageJsonExists() {
+	return (typeof getPackageJson() !== 'undefined');
+}
+
+function getBowerJson() {
+	return requireIfExists(path.join(process.cwd(), '/bower.json'));
+}
+
+function bowerJsonExists() {
+	return (typeof getBowerJson() !== 'undefined');
+}
+
 function getMainSassPath() {
 	var sassMainPath = path.join(process.cwd(), '/main.scss');
 	var bowerJson = getBowerJson();
@@ -23,9 +47,9 @@ function getMainSassPath() {
 		}
 	}
 	if (isInBowerMain && !fileExists) {
-		log.primaryError("main.scss is listed in bower.json main, but file doesn't exist.");
+		log.primaryError('main.scss is listed in bower.json main, but file doesn\'t exist.');
 	} else if (!isInBowerMain && fileExists) {
-		log.primaryError("main.scss exists but is not listed in bower.json main.");
+		log.primaryError('main.scss exists but is not listed in bower.json main.');
 	}
 	if (isInBowerMain && fileExists) {
 		return sassMainPath;
@@ -35,10 +59,10 @@ function getMainSassPath() {
 }
 
 function getMainJsPath() {
-	var jsMainPath = path.join(process.cwd(), '/main.js'),
-		bowerJson = getBowerJson(),
-		fileExists = fs.existsSync(jsMainPath),
-		isInBowerMain = false;
+	var jsMainPath = path.join(process.cwd(), '/main.js');
+	var bowerJson = getBowerJson();
+	var fileExists = fs.existsSync(jsMainPath);
+	var isInBowerMain = false;
 	if (bowerJson) {
 		if (bowerJson.main instanceof Array && bowerJson.main.indexOf('main.js') > -1) {
 			isInBowerMain = true;
@@ -47,9 +71,9 @@ function getMainJsPath() {
 		}
 	}
 	if (isInBowerMain && !fileExists) {
-		log.primaryError("main.js is listed in bower.json main, but file doesn't exist.");
+		log.primaryError('main.js is listed in bower.json main, but file doesn\'t exist.');
 	} else if (!isInBowerMain && fileExists) {
-		log.primaryError("main.js exists but is not listed in bower.json main.");
+		log.primaryError('main.js exists but is not listed in bower.json main.');
 	}
 	if (isInBowerMain && fileExists) {
 		return jsMainPath;
@@ -58,43 +82,19 @@ function getMainJsPath() {
 	}
 }
 
-function requireIfExists(path) {
-	if (fs.existsSync(path)) {
-		return require(path);
-	} else {
-		return undefined;
-	}
-}
-
-function getPackageJson() {
-	return requireIfExists(path.join(process.cwd(), '/package.json'));
-}
-
-function packageJsonExists() {
-	return (typeof getPackageJson() !== "undefined");
-}
-
-function getBowerJson() {
-	return requireIfExists(path.join(process.cwd(), '/bower.json'));
-}
-
-function bowerJsonExists() {
-	return (typeof getBowerJson() !== "undefined");
-}
-
 function getModuleName() {
 	var bowerJson = getBowerJson();
 	if (bowerJson) {
 		return bowerJson.name;
 	}
-	return "";
+	return '';
 }
 
 function recursiveFileSearch(root, ext) {
 	return new Promise(function(resolve) {
-		var excluded = ['.git', '.idea', 'bower_components', 'node_modules'],
-			finder = find(root),
-			files = [];
+		var excluded = ['.git', '.idea', 'bower_components', 'node_modules'];
+		var finder = find(root);
+		var files = [];
 		finder.on('directory', function(dir, stat, stop) {
 			var base = path.basename(dir);
 			if (excluded.indexOf(base) > -1) {
@@ -113,17 +113,17 @@ function recursiveFileSearch(root, ext) {
 }
 
 function getSassFilesList() {
-	return recursiveFileSearch(process.cwd(), ".scss");
+	return recursiveFileSearch(process.cwd(), '.scss');
 }
 
 function sassSupportsSilent(files) {
 	return new Promise(function(resolve, reject) {
-		var supportsSilent = false,
-			moduleName = getModuleName();
+		var supportsSilent = false;
+		var moduleName = getModuleName();
 		if (moduleName) {
 			for (var c = 0; c < files.length; c++) {
-				var fileContents = fs.readFileSync(files[c], { encoding: "utf-8" });
-				if (fileContents.indexOf(moduleName + "-is-silent") >= 0) {
+				var fileContents = fs.readFileSync(files[c], { encoding: 'utf-8' });
+				if (fileContents.indexOf(moduleName + '-is-silent') >= 0) {
 					supportsSilent = true;
 					break;
 				}
@@ -135,25 +135,23 @@ function sassSupportsSilent(files) {
 	});
 }
 
-/**
- * Get the node_modules directory that will be used when `npm install` is run
- * in the current working directory (process.cwd()). This is necessary as npm walks up the
- * directory tree until it finds a node_modules directory when npm installing.
- */
+// Get the node_modules directory that will be used when `npm install` is run
+// in the current working directory (process.cwd()). This is necessary as npm walks up the
+// directory tree until it finds a node_modules directory when npm installing.
 function getNodeModulesDirectoryInUse() {
 	return new Promise(function(resolve, reject) {
 		npmconf.load({}, function(err, conf) {
 			if (err) {
 				reject(err);
 			}
-			conf.findPrefix(process.cwd(), function(err, pathPrefix) {
-				if (err) {
-					reject(err);
+			conf.findPrefix(process.cwd(), function(e, pathPrefix) {
+				if (e) {
+					reject(e);
 				}
 				var nodeModulesPath = pathPrefix;
 
 				if (pathPrefix) {
-					nodeModulesPath = path.join(pathPrefix, "node_modules");
+					nodeModulesPath = path.join(pathPrefix, 'node_modules');
 				}
 
 				resolve(nodeModulesPath);

lib/helpers/log.js

@@ -4,7 +4,7 @@ require('colors');
 
 var debugLog = function() {};
 
-if (process.env.OBT_DEBUG === "true") {
+if (process.env.OBT_DEBUG === 'true') {
 	debugLog = function(text) {
 		console.log(String(text).grey);
 	};

lib/helpers/update-notifier.js

@@ -3,6 +3,7 @@
 require('colors');
 
 var https = require('https');
+var path = require('path');
 var Configstore = require('configstore');
 var semver = require('semver');
 var log = require('./log');
@@ -39,7 +40,7 @@ function checkVersion() {
 }
 
 function getCurrentVersion() {
-	return require(__dirname + '/../../package.json').version;
+	return require(path.join(__dirname, '/../../package.json')).version;
 }
 
 function updateNotifier() {