feat: introduce o-normalise to o-private-foundation #1864
Conversation
frshwtr
force-pushed
the
2025-release-private-foundation
branch
from
4e922d8
to
4db0a45
Compare
| @@ -0,0 +1,12 @@ | |||
| import PrivateFoundation from './src/js/private-foundation.js'; | |||
There was a problem hiding this comment.
Let's delete this and all JS
| /// 'body': ('font-smoothing', 'focus', 'reduce-motion') | ||
| /// )); | ||
| /// @access public | ||
| @mixin oNormalise($opts: ( |
There was a problem hiding this comment.
As far as I know, no Origami component calls oNormalise so we can delete this?
There was a problem hiding this comment.
Ah yes, I assumed stories were going to be updated to use private foundation, but it doesn't seem to matter so much in this case.
There was a problem hiding this comment.
Yeah let's exclude demos/devDeps
| @@ -0,0 +1,312 @@ | |||
| /// Visually hide an element while still | |||
| /// allowing it to be read by a screenreader | |||
| @mixin oNormaliseVisuallyHidden { | |||
There was a problem hiding this comment.
@import makes all variables, mixins, and functions globally accessible. These will conflict with o-normalise as projects work to migrate to o3.
- Which mixins, functions, and variables can we delete? We only need to keep them if they are called by other o2 components.
- For those that remain, let's use @use but also rename for good measure. We'll need to make changes to Sass of other components and so it's probably better to keep them separate.
There was a problem hiding this comment.
👍 I will prefix any of these remaining functions with oPrivate and kept the rest of the name the same.
components/o-typography/main.scss
Outdated
| @@ -4,7 +4,7 @@ | |||
| @import '@financial-times/o-fonts/main'; | |||
| @import '@financial-times/o-colors/main'; | |||
| @import '@financial-times/o-icons/main'; | |||
| @import '@financial-times/o-normalise/main'; | |||
| @import '@financial-times/o-private-foundation/o-normalise/main'; | |||
There was a problem hiding this comment.
FYI o-typography, o-buttons, etc will become part of o-private-foundation. Based on changes proposed in other comments, it might be easier to leave their dependency on o-normalise for now until they are subsumed
frshwtr
force-pushed
the
2025-release-private-foundation
branch
from
21d2943
to
631a319
Compare
notlee
force-pushed
the
2025-release-private-foundation
branch
from
631a319
to
12ae399
Compare
frshwtr
force-pushed
the
2025-release-o-normalise
branch
from
9775454
to
c3774b5
Compare
| @@ -1,5 +1,5 @@ | |||
| @import '@financial-times/o-typography/main'; | |||
| @import '@financial-times/o-normalise/main'; | |||
| @financial-times/o-normalise/main | |||
frshwtr
force-pushed
the
2025-release-o-normalise
branch
from
b510e4c
to
ddd6376
Compare
Describe your changes
Issue ticket number and link
Link to Figma designs
Checklist before requesting a review
percylabel for o-[COMPONENT] orchromaticlabel for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md