Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Bug fixes #32

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

spooksbit
Copy link
Contributor

Addresses two issues from #31

  1. When exporting the keys disappear from the UI.
    • This happened because the credentials list that was bound to the UI was being cleared. I don't think that needs to be cleared since the data is only being written out. Alternatively, and additional Add() could be included in the foreach loop as well.
  2. When exporting, the password is not being serialized

Call RetrievePassword to populate the password field.
@spooksbit
Copy link
Contributor Author

Fwiw the second issue looks like an undocumented quirk in between Retrieve and RetrieveAll. From the looks of it, Retrieve really does populate the password field as if it's calling RetrievePassword implicitly, which is why GetKey works as expected. That does not seem to be the case for RetrieveAll, which has all the password fields unpopulated. MSDN doesn't really make this distinction from what I can see, so I guess they just figured "they're looking for something specific, so populate the password field for them" but that contradicts their statements around needing to call RetrievePassword in their documentation.

@FireCubeStudios
Copy link
Owner

Ok I am checking these changes out to confirm things work and will merge. I will probably do an earlier store release than the next feature release to address bugs only 👍

@FireCubeStudios FireCubeStudios merged commit a0fcc6a into FireCubeStudios:master Sep 6, 2022
@FireCubeStudios
Copy link
Owner

Merged! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants