-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Support Firebase JS SDK 5.1 and Firestore with v3 #553
Conversation
This comment has been minimized.
This comment has been minimized.
… have different adapters
I've published on NPM under
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a quick test:
- I noticed, that
ember-simple-auth
cannot be optional, it has be installed to the project withember install ember-simple-auth
. (v1.8.1 is installed) - The default adapter configuration changed and has to be updated to
FirestoreAdapter
as you already mentioned in the new guide
import FirestoreAdapter from 'emberfire/adapters/firestore';
export default FirestoreAdapter.extend({
});
- After my demo app compiled and opened, when the router wanted to access to the store/adapter first time, the following error appeared:
Class constructor FirestoreAdapter cannot be invoked without 'new' TypeError: Class constructor FirestoreAdapter cannot be invoked without 'new'
My app uses Ember / EmberData v3.4 LTS.
Yeah I'll make simple auth an optional dependency. Also I noticed that the serializer isn't coming in, so you'll want to create an application serializer that extends the one in Emberfire. I'll fix that shortly. Not sure about your 'new' issue. Might be the ember version. |
@zoltan-nz I ran into the same error you did:
Did you ever figure it out? |
@samselikoff do you use Ember v3.4? I think, the latest beta version of EmberFire works fine with Ember v3.5+ So the solution was to upgrade Ember. I would say, we should use EmberFire v2 until Ember v3.4 and use EmbeFire v3(beta) with Ember v3.5+ |
Description
This is a work in progress! A lot has changed since version 2 of emberfire was released. We wanted our third major release to work great with Ember v3+, Fastboot, Cloud Firestore, Cloud Functions, and modern security rules out of the box. We want to also deal completely with the weak points of version 2; namely relationships, querying, and performance.
Given all that has changed and all we want to accomplish, we thought best to rewrite.
I'll write up some more as this release closes but I wanted to throw my work in progress up here for people to check out. The work here is loosely based on my v3 proposal here #542 (I've refined a couple details while taking feedback and building things out).
Related issues #546 , #552 , #531, #529, #522, #512, #511, #465, #461, #400, etc.
To try out this branch run
ember install emberfire-exp
.Code sample
Cloud Firestore adapter with offline-persistence enabled
Firestore backed model with embedded records, subcollections, and queries
Route demonstrating Firestore querying capabilities & realtime route mixin
Firebase app service and
ember-simple-auth
integrationSupport for multiple Firebase applications / services
After initialization there will now be a
service:firebase-app
andservice:firebase-second-app
ready for injection.TODO
Defined in
references to my node_modulesember-auto-import
,browserify
, andbrowserify-shim
as we near finalmore to come...