Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FirebaseCloudMessaging.cpp #268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michaelchien1972
Copy link

fix for https: instead of http:

fix for https: instead of http:
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@michaelchien1972
Copy link
Author

I signed it!

@michaelchien1972
Copy link
Author

michaelchien1972 commented Jul 14, 2017

In addition, some code changes may need to be done in ESP8266 Arduino bsp side.

File ESP8266HTTPClient.cpp

  1. get ride of WiFiClientSecure function to by pass the validation on SHA1 signature of Firebase server

`
class TLSTraits : public TransportTraits
{
public:
TLSTraits(const String& fingerprint) :
_fingerprint(fingerprint)
{
}

std::unique_ptr<WiFiClient> create() override
{
    //return std::unique_ptr<WiFiClient>(new WiFiClientSecure());
    return std::unique_ptr<WiFiClient>(new WiFiClient());
}

bool verify(WiFiClient& client, const char* host) override
{
    //auto wcs = reinterpret_cast<WiFiClientSecure&>(client);
    //return wcs.verify(_fingerprint.c_str(), host);
   return true;
}

protected:
String _fingerprint;
};
`

  1. force http to https

`
bool HTTPClient::begin(String url)
{
_transportTraits.reset(nullptr);

//_port = 80;
//if (!beginInternal(url, "http")) {
   //return false;
//}
_port = 443;
if (!beginInternal(url, "https")) {
    return false;
}
_transportTraits = TransportTraitsPtr(new TransportTraits());
return true;

}
`

@googlebot
Copy link

CLAs look good, thanks!

@proppy
Copy link
Collaborator

proppy commented Sep 8, 2017

cc'ing @ed7coyne

@proppy proppy added the arduino label Sep 8, 2017
@proppy
Copy link
Collaborator

proppy commented Jun 15, 2018

Also see #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants