Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #88 #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

koalter
Copy link

@koalter koalter commented Sep 8, 2023

No description provided.

@google-cla
Copy link

google-cla bot commented Sep 8, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rgant
Copy link

rgant commented Sep 11, 2023

This is not the correct fix for this problem.

The issue (for me) is that @angular/[email protected] is using firebase@9 which is still using @firebase/[email protected] but rxfire is expecting @firebase/firestore@4.

  └─┬ [email protected]
    ├─┬ @firebase/[email protected]
    │ └── @firebase/[email protected] deduped
    └── @firebase/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants