Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add citations with publicationDate #22

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

andrewheard
Copy link
Collaborator

Updated the citations examples (unary and streaming) to include a citation with a publicationDate.

Copy link

Coverage Diff

GenerateContentResponse: 43
| candidates: 38
| | citationMetadata: 4
| | | citations: 4
| | | | publicationDate: 0 -> 2 ✅
| | | | | day: 0 -> 2 ✅
| | | | | month: 0 -> 2 ✅
| | | | | year: 0 -> 2 ✅
Total Coverage: 41.43% -> 44.29% ✅

Legend:
✅ : total coverage increase
🔵 : files number increase, total coverage unaffected
🟡 : files number decrease, total coverage unaffected
❌ : total coverage decrease

@andrewheard
Copy link
Collaborator Author

Note: The failing JS Unit Test is pre-existing (firebase/firebase-js-sdk#8566). The citations tests are still passing.

@andrewheard andrewheard marked this pull request as ready for review October 15, 2024 18:11
@andrewheard andrewheard merged commit 60d747e into main Oct 15, 2024
8 of 9 checks passed
@andrewheard andrewheard deleted the ah/citations-pub-date branch October 15, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants