Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverage Tool] Update DISCOVERY_DOC_URL to firebasevertexai #24

Merged
merged 2 commits into from
Oct 31, 2024
Merged

[Coverage Tool] Update DISCOVERY_DOC_URL to firebasevertexai #24

merged 2 commits into from
Oct 31, 2024

Conversation

andrewheard
Copy link
Collaborator

@andrewheard andrewheard commented Oct 30, 2024 •
edited
Loading

Updated the DISCOVERY_DOC_URL from https://aiplatform.googleapis.com/$discovery/rest?version=v1beta1 to https://firebasevertexai.googleapis.com/$discovery/rest?version=v1beta since the SDKs only care about services, fields, etc., offered by the Vertex AI in Firebase proxy.

Note: Coverage is currently identical since coverage_tool.py filters by RESPONSE_TYPES = ["GenerateContentResponse", "CountTokensResponse"].

@github-actions GitHub Actions
Copy link

Coverage Diff

Coverage is identical

@andrewheard andrewheard marked this pull request as ready for review October 30, 2024 22:32
@andrewheard andrewheard requested a review from rlazo October 30, 2024 22:32
@rlazo rlazo merged commit 6069992 into main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @rlazo