Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding tags #40

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Allow overriding tags #40

wants to merge 4 commits into from

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Mar 17, 2023

If running this action outside of the context of push or pull_request (generally, any situation where you may have run actions/checkout with a ref override), the image tags may have an undesirable value - I've observed this with a workflow_dispatch trigger where the ref is an input parameter.

I'm not entirely sure that providing the value is the correct behavior, beyond possibly trying to improve the commit inference in the action (e.g. run actual git commands). However this is still useful if the desired tag format doesn't match an an existing build convention, etc (e.g. using short commits)

@Firehed Firehed marked this pull request as ready for review March 17, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant