Remove all non-inheritable extensions from the base profile before snapshotting #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewoutkramer
requested changes
Oct 14, 2024
| @@ -2433,8 +2433,8 @@ private static bool isAlmostExactly(ElementDefinition elem, ElementDefinition ba | |||
| } | |||
|
|
|||
| // Also ignore any Changed extensions on base and diff | |||
| elemClone.RemoveAllConstrainedByDiffExtensions(); | |||
| baseClone.RemoveAllConstrainedByDiffExtensions(); | |||
| elemClone.RemoveAllNonInheritableExtensions(); | |||
There was a problem hiding this comment.
Does this method replace the original ones? So RemoveallNonInheritableExtension replaces RemoveAllConstrainedByDiffExtensions? If so, should we not remove/obsolete the original method?
| @@ -73,6 +72,47 @@ public static void RemoveAllConstrainedByDiffExtensions<T>(this IEnumerable<T> e | |||
| } | |||
| } | |||
|
|
|||
| internal static void RemoveAllNonInheritableExtensions(this Element element) | |||
There was a problem hiding this comment.
Can we use a bit code in a shared project instead of copy/paste? I know the snapget is unique to both, but maybe this overlaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1814