Replace PocoBuilder to support overflow #2953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kasdejong
requested changes
Nov 13, 2024
src/Hl7.Fhir.Support.Poco.Tests/Model/TypedElementToPocoTests.cs
Outdated
Show resolved
Hide resolved
Base automatically changed from
6.0/parse-elements-for-xml-parsers
to
develop-6.0
November 13, 2024 14:54
…e-overflow' into 6.0/2947-adapt-pocobuilder-to-use-overflow
ewoutkramer
changed the title
Kasdejong
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote a replacement for PocoBuilder (for now, called PocoBuilderNew, they are internal classes anyway) that implements the new overflow and uses the Dynamic datatype classes for unknown types.
ToPoco()extension methods to use the new builderFixes #2947 .
Breaking changes
DefaultModelFactoryhas been removed. It had not been in use for years, except by our own tests. With the cleanup of the PocoBuilder (ITypedElement->POCO) infrastructure, we decided to remove this class.