Add several minor fixes #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MC952-arch
commented
Feb 7, 2025
MC952-arch
commented
- Invoke event block call in WorkFlagCX::wait func
- Add plugin/torch/run_hetero.sh script for heterogeneous test
- Reuse sync stream as a substitution of barrier op for better performance
aoyulong
reviewed
Feb 8, 2025
plugin/torch/example.py
Outdated
There was a problem hiding this comment.
Please refactor this file in a more modular way in the future.
Comment on lines
+141
to
+144
| if (!coalesced_) | ||
| { | ||
| event_->block(device_id_); | ||
| } | ||
| if (isBarrierOp_) |
There was a problem hiding this comment.
What is the reason for this code working now?
There was a problem hiding this comment.
What is the reason for this code working now?
It seems that a sync stream call is required after flagcxHeteroSend/Recv ops. Such synchronization is added in all C2C algorithms for the moment. Here we adopt the same way as ProcessGroupNCCL does, blocking current stream on the flagcx stream.
aoyulong
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.