Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returning type was only
np.ndarray
, but it is possible to change the return type totorch.Tensor
if we setconvert_to_numpy
toFalse
. The origin version can lead to wordy and inefficient codes because people don't know thatencode()
can return Tensor. For example, the code in Tutorial usesencode()
as follow:which has to convert the tensor to np.ndarray and then convert it into Tensor.
This code can be changed into:
embeddings = model.encode([sentence_1, sentence_2, sentence_3], convert_to_numpy=False)
which is more effective.