Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Add python-test config yaml for Unit Test #42

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

Bowen12992
Copy link
Collaborator

Add .github/workflows/python-test.yaml for deployment of CI/CD

container:
image: localhost:5000/flag-gems-ci:v1.0
env:
NODE_ENV: development
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this environment NODE_ENV for?

Copy link
Collaborator Author

@Bowen12992 Bowen12992 May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a redundant env from the template file which i forgot to delete. BTW, we should use PYTHON_ENV: production for this project if an env needed.

Copy link
Collaborator

@iclementine iclementine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bowen12992 Bowen12992 merged commit a681112 into master May 31, 2024
@Bowen12992 Bowen12992 changed the title [ci/cd] Add python-test config yaml for Unit Test [CI/CD] Add python-test config yaml for Unit Test Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants